Added unit tests - #36
Open
exlegalalien wants to merge 2 commits into
Open
Conversation
exlegalalien
commented
Jul 24, 2026
exlegalalien
commented
Contributor
- Added unit tests
- Updated CodeQL workflow
- Updated to the latest versions of 3rd party modules
|
@exlegalalien Is this really something that should be pushed (emailed out) to the entire engineering department for review? |
Contributor
Author
@zcarsco No, it is not, but unfortunately this isn't something I have control over. Based on the repo's settings this happens automatically when a PR is opened, since zimperium/engineering (with 74 members) is the repo's owner. I am just a lowly contributor and cannot change that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.