Fix baseUrl reassignment error when trimming trailing slash - #33
Closed
ZimperiumBrian wants to merge 4 commits into
Closed
Fix baseUrl reassignment error when trimming trailing slash#33ZimperiumBrian wants to merge 4 commits into
ZimperiumBrian wants to merge 4 commits into
Conversation
exlegalalien
requested review from
exlegalalien
and removed request for
a team
December 22, 2025 15:03
Contributor
|
Will fix in a separate branch/PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When
console_urlends with a trailing slash, the action attempts to normalize it by trimming the slash.However,
baseUrlis currently declared asconst, which causes a runtime crash when reassignment is attempted.Evidence
GitHub Actions runtime error:
Fix
Change
const baseUrltolet baseUrlso trailing-slash normalization works correctly.Impact
Prevents the action from crashing when users configure
console_urlwith a trailing slash.This aligns with the existing normalization logic already present in the code.