Drop consumer-side libcint pkg-config probe from Config.cmake.in#92
Merged
Conversation
The pkg_check_modules(LIBCINT REQUIRED libcint>=5.3.0) call ran at consumer find_package(SlaterGPU) time but had no functional value: its LIBCINT_* output variables were never appended to SlaterGPU_LIBRARIES or otherwise wired up. libcint is already carried as a transitive dep via IMPORTED_LINK_DEPENDENT_LIBRARIES_RELEASE -> SlaterGPU::cint, auto-promoted from the find_library path during install(EXPORT). The probe also broke downstream pixi builds where libcint isn't on pkg-config's search path, surfacing as the configure-time error "No package 'libcint' found". This was previously masked in ZEST and XCtera by a workaround that bypassed CONFIG mode entirely. Refs #88. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkg_check_modules(LIBCINT REQUIRED libcint>=5.3.0)(and thefind_dependency(PkgConfig REQUIRED)it required) fromSlaterGPUConfig.cmake.in.LIBCINT_*output vars were never wired intoSlaterGPU_LIBRARIESor any imported target. libcint is already carried as a transitive dep viaIMPORTED_LINK_DEPENDENT_LIBRARIES_RELEASE -> SlaterGPU::cint(auto-promoted from thefind_librarypath duringinstall(EXPORT)).pkg-configin the consumer's environment — surfacing asNo package 'libcint' foundat consumer-sidefind_package(SlaterGPU)time. This was previously masked in ZEST and XCtera by a workaround block that bypassed CONFIG mode entirely (see Investigate imported-target workaround in downstream consumers; fix or simplify #88).Why it's safe
After this change, a consumer doing
find_package(SlaterGPU)+target_link_libraries(... SlaterGPU::cintw)still gets a clean link chain — verified locally with both ZEST and XCtera builds, both Release and Debug consumer configurations.lddon the resulting binaries shows the full chain:CMake's documented
IMPORTED_CONFIGURATIONSauto-fallback handles Debug consumers linking against the only-available Release artifacts, so noMAP_IMPORTED_CONFIG_*shim is needed.Sequencing
This PR should merge before the companion ZEST and XCtera cleanup PRs (filed under #88), since those PRs delete the workaround that has been masking this bug.
Test plan
lddcleanlddcleancmake -DCMAKE_BUILD_TYPE=Debugconfigure of ZEST against this SlaterGPU produces a cleanlink.txtwith all four expected artifactsRefs #88.
🤖 Generated with Claude Code