Set contract address to empty string if missing in response - #123
Open
chetan-zilliqa wants to merge 2 commits into
Open
Set contract address to empty string if missing in response#123chetan-zilliqa wants to merge 2 commits into
chetan-zilliqa wants to merge 2 commits into
Conversation
chetan-zilliqa
requested review from
JamesHinshelwood,
rrw-zilliqa and
saeed-zil
October 22, 2024 07:41
saeed-zil
previously approved these changes
Oct 23, 2024
saeed-zil
approved these changes
Oct 24, 2024
chetan-zilliqa
enabled auto-merge (squash)
October 30, 2025 07:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The contract address is not included in the response in ZQ2. Set it to an empty string if the contract_address field is missing. This should resolve #122.
Review Suggestion
Status
Implementation