Skip to content

added windows check for delimiters #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RohanVashisht1234 merged 1 commit into from
Nov 19, 2025
Merged

added windows check for delimiters #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions install_script.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,5 @@ fi

cd ~
echo "Done!"

echo "Please star ⭐️ zigp repo: https://github.com/zigistry/zigp"
7 changes: 6 additions & 1 deletion src/libs/helper_functions.zig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ const std = @import("std");
const ansi = @import("./ansi_codes.zig");
const types = @import("../types.zig");
const display = @import("display.zig");
const builtin = @import("builtin");

const MAX_ALLOWED_REPO_NAME_LENGTH = 2000;
const releases_url = "https://api.github.com/repos/{s}/releases";
Expand Down Expand Up @@ -203,7 +204,11 @@ pub fn read_integer() !usize {

// Windows terminal compatibility issues
// Trim the carriage return
const num_str = std.mem.trim(u8, num_str_cr, " \r\n\t");
const delimiters = switch (builtin.target.os.tag) {
.windows => " \n\t",
else => " \r\n\t",
};
const num_str = std.mem.trim(u8, num_str_cr, delimiters);

std.debug.print("\n", .{});
const parsed_int = std.fmt.parseInt(usize, num_str, 10) catch |err| {
Expand Down