Feature/better xml handling

[phillipadsmith]

No description provided.

[TonyDeStefano]

Hiya. I haven't even thought about this repo in years lol. Can you add tidy to the composer.json file as well so it knows what dependencies it needs?

[phillipadsmith]

Hiya. I haven't even thought about this repo in years lol. Can you add tidy to the composer.json file as well so it knows what dependencies it needs?

Tidy is included in PHP. :)

https://www.php.net/manual/en/book.tidy.php

[TonyDeStefano]

Oh ok, I thought it was something that needed to be compiled into PHP and wasn't standard. If it's baked into PHP by default, then we are good to go.

[TonyDeStefano]

Usually I like to put the non-standard extensions into the composer.json require section like so:

"ext-tidy": "*"

[phillipadsmith]

Usually I like to put the non-standard extensions into the composer.json require section like so:

Happy to do that.

[phillipadsmith]

Hey there @TonyDeStefano: I've updated the requirements. Thanks for your patience on this!

[phillipadsmith]

Hmmm... interesting. So, installing this on a new system, I had this experience:

zaycon/whatcounts dev-feature/better-xml-handling requires ext-tidy * -> the requested PHP extension tidy is missing from your system.

Which seems like the correct behaviour, as this extension needs to be uncommented in the php.ini

But, for a fresh system, I would also need to do this:

sudo apt-get install php-tidy

From there, composer install works fine, but I do get this odd message:

PHP Warning: Module 'tidy' already loaded in Unknown on line 0

[phillipadsmith]

PHP Warning: Module 'tidy' already loaded in Unknown on line 0

Seems this is because sudo apt-get install php-tidy installs the extension and uncommenting the line in php.ini is unnecessary.

[TonyDeStefano]

Well crap. I no longer have admin access to this repo so I can't even merge the PR. I guess they took away my rights when I left that company. And now that company is completely shut down, so this repo is basically dead. Boo.