work needed for adding coin 3 and coin 4 inputs

[mogorman]

other part of ZaparooProject/zaparoo-core#859

Summary by CodeRabbit

Release Notes

• New Features

  • Added support for coin input types 3 and 4. This expands the coin input capabilities to support a total of four coin-operated input devices, complementing the existing keyboard and gamepad input options available.

• Documentation

  • Updated the supported commands list to reflect the newly available coin input types.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR extends ZapScript's coin input command support by adding two new command constants (input.coinp3 and input.coinp4) to the models package and updating the AGENTS.md documentation to reflect the expanded supported input commands list.

Changes

Coin Input Command Extension

Layer / File(s)	Summary
Add coin input commands P3 and P4 models.go, AGENTS.md	New constants ZapScriptCmdInputCoinP3 and ZapScriptCmdInputCoinP4 are defined, and the agent documentation is updated to include these commands in the supported Input command enumeration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through coin-fed dreams,
P3, P4, expanding streams,
Commands documented, clean and bright,
Input support takes new flight! 🐰💰

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title accurately describes the main change: adding support for coin 3 and coin 4 inputs by introducing new command constants and documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@models.go`:
- Around line 59-60: The new public constants ZapScriptCmdInputCoinP3 and
ZapScriptCmdInputCoinP4 lack unit tests; add tests that parse/serialize these
command strings and assert round-trip equality and parser acceptance (e.g., a
test that feeds "input.coinp3" and "input.coinp4" into the existing parser and
verifies the produced model uses the corresponding constant and that serializing
the model yields the same command string), include negative/edge cases if your
parser supports variations, and place tests alongside existing model/parser
tests so future changes to ZapScriptCmdInputCoinP3 and ZapScriptCmdInputCoinP4
will be caught.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 386d2a33-f705-4853-968f-0b39a7a2274e

📥 Commits

Reviewing files that changed from the base of the PR and between 63a13b1 and d201517.

📒 Files selected for processing (2)

• AGENTS.md
• models.go

[coderabbitai]

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add tests for the new input command constants.

These new public command values should be covered by tests (at least parser acceptance / model round-trip) so support for input.coinp3 and input.coinp4 doesn’t regress silently.

As per coding guidelines: “Do not skip writing tests for new features or bug fixes” and “Write tests for all new code with comprehensive coverage required.”

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@models.go` around lines 59 - 60, The new public constants
ZapScriptCmdInputCoinP3 and ZapScriptCmdInputCoinP4 lack unit tests; add tests
that parse/serialize these command strings and assert round-trip equality and
parser acceptance (e.g., a test that feeds "input.coinp3" and "input.coinp4"
into the existing parser and verifies the produced model uses the corresponding
constant and that serializing the model yields the same command string), include
negative/edge cases if your parser supports variations, and place tests
alongside existing model/parser tests so future changes to
ZapScriptCmdInputCoinP3 and ZapScriptCmdInputCoinP4 will be caught.