Fix the size of active set and shadow set reported#281
Open
LJS42 wants to merge 3 commits into
Open
Conversation
Member
|
good catch! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
==========================================
- Coverage 86.23% 84.31% -1.92%
==========================================
Files 17 22 +5
Lines 1482 2640 +1158
==========================================
+ Hits 1278 2226 +948
- Misses 204 414 +210 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dhendryc
requested changes
Feb 3, 2026
Comment on lines
+112
to
+121
| node = tree.nodes[tree.root.current_node_id[]] | ||
|
|
||
| if active_set != nothing | ||
| node.active_set_size = length(active_set) | ||
| end | ||
|
|
||
| if use_DICG && pre_computed_set != nothing | ||
| node.discarded_set_size = length(pre_computed_set) | ||
| end | ||
|
|
Member
There was a problem hiding this comment.
It would be better to move this into evaluate_node!. The shadow set size has to be set the same way, I would think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The active set and shadow set sizes were being reported as 0 in example portfolio.jl.