fix(core): use [warning] markup in uninstall() to match install() style#666
Open
AviArora02-commits wants to merge 1 commit intoZ4nzu:masterfrom
Open
fix(core): use [warning] markup in uninstall() to match install() style#666AviArora02-commits wants to merge 1 commit intoZ4nzu:masterfrom
AviArora02-commits wants to merge 1 commit intoZ4nzu:masterfrom
Conversation
Uninstall commands were printed in red ([error]) which falsely implied a failure. Changed to [warning] (yellow) to be consistent with how install() displays commands — informational, not alarming. Fixes Z4nzu#662
Author
|
Ready for review!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #662
What changed
In
core.py, theuninstall()method was printing each command with[error]markup (red),while
install()correctly uses[warning]markup (yellow) for the same purpose —displaying a command before running it.
Why it matters
Red output signals an error to users. Seeing red text during a successful uninstall
is confusing and alarming. This change makes the UX consistent and honest.
Change
core.pyline 228:[error]→[warning]Testing
matching the install() method behavior.