[code-simplifier] Simplify int_cube: remove goto, use aggregate/brace init#9874
Open
NikolajBjorner wants to merge 1 commit into
Open
[code-simplifier] Simplify int_cube: remove goto, use aggregate/brace init#9874NikolajBjorner wants to merge 1 commit into
NikolajBjorner wants to merge 1 commit into
Conversation
Replace goto-based control flow in get_cube_delta_for_term with an all_ok flag for structured early-exit. Use aggregate initialization for flip_candidate, constructor-based vector sizing for occs, brace initialization for pairs in add_edge_rows_for_term. No functional changes - all lcube tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
levnach
reviewed
Jun 15, 2026
levnach
left a comment
levnach
left a comment
Contributor
There was a problem hiding this comment.
Rename variable all_ok to octagon_row.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace goto-based control flow in get_cube_delta_for_term with an all_ok flag for structured early-exit. Use aggregate initialization for flip_candidate, constructor-based vector sizing for occs, brace initialization for pairs in add_edge_rows_for_term.
No functional changes - all lcube tests pass.