Skip to content

[codex] Update JavaScript dependencies#8

Merged
YurMil merged 1 commit into
mainfrom
codex/update-dependencies
May 17, 2026
Merged

[codex] Update JavaScript dependencies#8
YurMil merged 1 commit into
mainfrom
codex/update-dependencies

Conversation

@YurMil

@YurMil YurMil commented May 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • Consolidated the Dependabot dependency updates into one branch.
  • Updated the main JavaScript/tooling stack:
    • @types/node to ^25.8.0
    • express to ^5.2.1
    • @types/express to ^5.0.6
    • lucide-react to ^1.16.0
    • Vite tooling to current latest versions: vite ^8.0.13, @vitejs/plugin-react ^6.0.2, @tailwindcss/vite ^4.3.0, tailwindcss ^4.3.0, esbuild ^0.28.0, tsx ^4.22.1, typescript ~6.0.3
  • Added missing React typings required by the stricter TypeScript 6 check.
  • Added src/vite-env.d.ts for Vite asset/CSS module typing.
  • Updated server.ts for Express 5 route compatibility and PORT env support.
  • Excluded generated dist output from TypeScript checks.

Why

This replaces the separate Dependabot dependency PRs with one coherent update so peer dependencies are resolved together, especially the Vite 8 / plugin-react 6 / esbuild 0.28 set.

Validation

  • npm install
  • npm run lint
  • npm run build
  • npm test
  • npm outdated --json returns {}
  • npm audit --audit-level=moderate reports 0 vulnerabilities
  • Production Express server verified locally with PORT=4174 NODE_ENV=production npx tsx server.ts
  • Verified /api/skills response and SPA fallback route on the production server

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Updated (UTC)
✅ Deployment successful!
View logs
askillbuilder e7c306a May 17 2026, 12:40 PM

@YurMil YurMil marked this pull request as ready for review May 17, 2026 12:41

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates project dependencies, configures the server to use environment variables for the port, and refines TypeScript configurations. However, several dependency versions specified in package.json (such as Vite 8 and TypeScript 6) do not exist in the public registry and will cause build failures. Additionally, it is recommended to use generics in the store for better type safety instead of manual type assertions in the components.

Comment thread package.json
Comment on lines +14 to +27
"@tailwindcss/vite": "^4.3.0",
"@vitejs/plugin-react": "^6.0.2",
"@xyflow/react": "^12.10.2",
"cors": "^2.8.6",
"dotenv": "^17.2.3",
"express": "^4.21.2",
"express": "^5.2.1",
"file-saver": "^2.0.5",
"jszip": "^3.10.1",
"lucide-react": "^0.546.0",
"lucide-react": "^1.16.0",
"motion": "^12.23.24",
"nanoid": "^5.1.11",
"react": "^19.0.1",
"react-dom": "^19.0.1",
"vite": "^6.2.3",
"vite": "^8.0.13",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Several dependency versions specified in this block do not exist in the public npm registry. For example, vite is currently at version 6.x, express at 5.0.x, and lucide-react at 0.4xx. Specifying non-existent versions like vite ^8.0.13, express ^5.2.1, or lucide-react ^1.16.0 will cause npm install to fail. Please revert these to the latest stable versions.

Comment thread package.json
Comment on lines +32 to +42
"@types/express": "^5.0.6",
"@types/file-saver": "^2.0.7",
"@types/node": "^22.14.0",
"@types/node": "^25.8.0",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"autoprefixer": "^10.4.21",
"esbuild": "^0.25.0",
"tailwindcss": "^4.1.14",
"tsx": "^4.21.0",
"typescript": "~5.8.2",
"vite": "^6.2.3"
"esbuild": "^0.28.0",
"tailwindcss": "^4.3.0",
"tsx": "^4.22.1",
"typescript": "~6.0.3",
"vite": "^8.0.13"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Multiple devDependencies in this section use hallucinated versions. TypeScript is currently at 5.7.x (version 6.0 does not exist), and @types/node ^25.8.0 is invalid as Node.js has not reached version 25. Additionally, esbuild ^0.28.0 and tsx ^4.22.1 are not available. These invalid versions will prevent the project from building. Please use valid, existing versions (e.g., typescript ~5.7.2, @types/node ^22.14.0).


const editingNode = nodes.find(n => n.id === editingNodeId);
const data = editingNode?.data;
const data = editingNode?.data as Partial<Skill> | undefined;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The type assertion as Partial<Skill> | undefined is used here to satisfy a 'stricter TypeScript 6 check' mentioned in the PR description. Since TypeScript 6 is not a valid version, this assertion may be unnecessary. A more robust approach would be to properly type the nodes array in the store using generics (e.g., Node<SkillNodeData>[]) to ensure the data property is correctly typed throughout the application without requiring manual assertions.

@YurMil YurMil merged commit e5e9ab8 into main May 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant