Skip to content

Do not list links without anchor description in DownloadPageAPI#50

Open
ewilly wants to merge 1 commit into
YunoHost:mainfrom
ewilly:patch-1
Open

Do not list links without anchor description in DownloadPageAPI#50
ewilly wants to merge 1 commit into
YunoHost:mainfrom
ewilly:patch-1

Conversation

@ewilly

@ewilly ewilly commented Oct 20, 2025

Copy link
Copy Markdown

Some webpages could have HREF in an anchor without description (<a href="url">description</a>) which lead in key with None value in the get_web_page_links list and result in erro in the autoupdate_app_sources.py script

@fflorent

Copy link
Copy Markdown
Contributor

No regression detected on my side.

I guess links with no description are not meant to be scrapped. That's arguable, we might want to just return links (href), but let's see in a future work(?)

At least, that patch does not prevent the autoupdate of Piwigo, if that makes the autoupdate work for Grafana, I am in favor.

@Salamandar

Copy link
Copy Markdown
Contributor

I don't get what you mean by "HREF in an anchor without description". Can you give me an example ?

@ewilly

ewilly commented Feb 25, 2026

Copy link
Copy Markdown
Author

For example in that page https://grafana.com/grafana/download?edition=oss there is <a href=https://twitter.com/grafana target=_blank rel=noopener aria-label="Grafana Labs on X"><i class="fa fa-twitter"></i></a>
so an anchor with an href without description <a href="url"></a> instead of <a href="url">description</a>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants