Remove label from GNode, move to node-label plugin#701
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
labelfrom the coreGNodetype — labels are a product-level concern, not a graph primitive@magic/graph-pluginspackage with acreateNodeLabelplugin that manages label assignment, storage, and theme wiringcreateNodeLabelinto all product graphs viauseGraph.ts{ id }instead of receiving a fullGNodeuseAdjacencyList— removeslabelAdjacencyListandfullNodeAdjacencyListwhich depended onGNode.labelnewNodeLabelGetterfromCoreGraphSettingsand the oldlabels.tscomposable.gitignorefiles into rootKnown issues / follow-ups
addElements) can assign duplicate labels due to aslice(0, -1)assumption in the label generator — tracked in [graph/plugins/node-label] bulk node additions assign duplicate labels #700treeArrayToGraph.tsstill passeslabeltoaddNodewith a@ts-expect-error migrationcomment; binary trees need a proper migration off label-based node idspackages/server/src/sockets.tsis commented out (pre-existing, unrelated to this PR)