[graph/canvas] refactor: graph theme naming overhaul#670
Merged
Conversation
Yonava
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #657
Restructures the theme API under a single canvas.theme namespace and tightens up naming throughout.
What changed
getTheme, themeMap, baseTheme, activeThemePreset, and useTheme are now grouped under canvas.theme as _resolveToken, _overrides, base, activePreset, and createLayer
useTheme.ts → createLayer.ts, getThemeResolver.ts → createTokenResolver.ts
ValidGraphThemePath → ThemeToken, FullThemeMap → ThemeOverrides, ThemeMapEntry → ThemeOverride
resolveThemeForNode / resolveThemeForEdge → getNodeStyles / getEdgeStyles
Layer controls shortened: setTheme / removeTheme / removeAllThemes → set / remove / removeAll
Background pattern drawing moved from the product layer (useGraphWithCanvas) into useCanvasPlugin where it belongs
Added a naming conventions glossary to types.ts (StyleValue / ThemeValue / ThemeToken)
Why
The old API was a flat bag of loosely related fields on canvas. Grouping them under canvas.theme makes the surface discoverable and draws a clear line between what plugins can use internally (_resolveToken, _overrides) and what consumers should reach for (createLayer). The full public read API for product code is tracked in #574.