feat(bulk-editor): link the row title to the post editor#23434
Open
JorPV wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an editor link to each bulk editor row title (with a plain-text fallback when no edit link is available), plus styling for hover/focus and a unit test to lock the behavior in.
Changes:
- Render the bulk editor row title as an
<a>to the post edit screen wheneditLinkis present; otherwise render plain text. - Add bulk-editor page CSS for hover/focus-visible underline + visited-state overrides.
- Add a unit test covering link rendering and the no-link fallback.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
packages/js/tests/bulk-editor/bulk-editor-table.test.js |
Adds coverage ensuring titles render as links when an edit URL exists and as plain text when it doesn’t. |
packages/js/src/bulk-editor/components/table/table-cells.js |
Updates TitleCell to conditionally render the title as an anchor to the edit screen. |
css/src/bulk-editor-page.css |
Implements the link’s hover/focus-visible underline animation and prevents visited-link tinting. |
Coverage Report for CI Build 11Coverage decreased (-5.8%) to 45.848%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Implements Yoast/reserved-tasks#1303: in the bulk editor, the post/page title in each row should be a link to that post's editor screen, with a hover state. The title now links to the single post editor screen (falling back to plain text when the item has no edit link).
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
::after, fades in via opacity) plus a slate-800 → slate-900 text darkening. A pseudo-element is used becausetext-decorationcannot animate.<a>, so ui-library's.yst-root a:visited/a:hover:visitedlink styling would otherwise tint followed links magenta. The rules include:visited/:hover:visited/:focus-visible:visitedselectors that outrank it, so followed links match unvisited ones.:focus:not(:focus-visible)), and the underline also appears on:focus-visible, preserving WCAG 2.4.7.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
[shopify-seo], added test instructions for Shopify and attached theShopifylabel to this PR.[yoast-doc-extension], added test instructions for Yoast SEO for Google Docs and attached theGoogle Docs Add-onlabel to this PR.Documentation
Quality assurance
Innovation
innovationlabel.Fixes Yoast/reserved-tasks#1303