Skip to content

fix(ci): resolve Docker build and auto-release failures #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YiWang24 merged 1 commit into from
May 26, 2026
Merged

fix(ci): resolve Docker build and auto-release failures #157

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ jobs:
if: steps.guard.outputs.skip != 'true' && steps.analyze.outputs.bump != 'none'
env:
NEW_TAG: ${{ steps.version.outputs.tag }}
GH_TOKEN: ${{ secrets.MY_GITHUB_TOKEN }}
GH_TOKEN: ${{ github.token }}

@greptile-apps greptile-apps Bot May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 github.token won't trigger release.yml on tag push

GitHub explicitly prevents GITHUB_TOKEN from triggering downstream workflow runs to avoid infinite loops. release.yml listens on push: tags: ["v*"], so when auto-release.yml creates a tag via the GitHub API using github.token, the tag event is silently swallowed and release.yml never starts. The summary step even says "Release workflow will be triggered automatically," which will no longer be true.

The original secrets.MY_GITHUB_TOKEN PAT was the right approach because a PAT does propagate push tag events. The correct fix is to provision (or reprovision) that secret — or replace it with a GitHub App installation token — rather than switching to github.token.

run: |
set -euo pipefail
echo "Creating tag: $NEW_TAG"
Expand Down
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ name: ci
on:
push:
branches: [main]
paths:
- "Dockerfile*"
- "docker-compose*.yml"
- ".dockerignore"
- "src/**"
- "*.dockerfile"
- ".github/workflows/ci.yml"
Comment on lines +9 to +15

@greptile-apps greptile-apps Bot May 26, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 harness-test job silently skipped on test-only changes

The paths filter applies to the entire ci.yml workflow, including the harness-test job. tests/** is not in the filter, so a push that only modifies BATS test files will not trigger the test suite on main. Since this repo IS the OpenCI library, changes to tests/ are a primary concern and should always exercise the BATS runner.

Adding "tests/**" (and optionally ".github/workflows/reusable-ci.yml") to the paths list would restore coverage for test-only commits.

workflow_dispatch:

permissions:
Expand Down
Loading