fix(reusable): correct preflight script path to .openci/.github/scripts/#149
Merged
Conversation
Scripts live in OpenCI and are vendored to .openci/ by resolve-openci.
All four callers were referencing .github/scripts/ (the caller repo's own
tree, where the scripts don't exist), causing exit 127 on Probe secrets.
- reusable-ci.yml: resolve-openci already ran; just fix the path
- reusable-stg.yml: resolve-openci already ran; just fix the path (2 calls)
- reusable-prd.yml: resolve-openci already ran; just fix the path (2 calls)
- reusable-pr.yml: preflight had no OpenCI vendor at all; add
resolve-openci step before Probe secrets and fix path.
Same fix applied to verify-sha job.
Fixes #148
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis PR redirects script invocations across four reusable GitHub Actions workflows to use a vendored OpenCI repository checkout at ChangesWorkflow Script Path Migration to Vendored OpenCI
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related issues
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #148
Root Cause
All reusable workflows vendor OpenCI into
.openci/viaresolve-openci, so scripts land at.openci/.github/scripts/. But four workflows were callingbash .github/scripts/preflight-secrets.sh— referencing the caller repo's own tree where the scripts don't exist — causing exit 127 on the Probe secrets step.reusable-pr.ymlhad an additional issue: thepreflightjob had no OpenCI vendor step at all, so there was nothing to call.Changes
reusable-ci.yml.github/→.openci/.github/reusable-stg.yml.github/→.openci/.github/(2 calls)reusable-prd.yml.github/→.openci/.github/(2 calls)reusable-pr.ymlpreflightresolve-opencistep + fix pathreusable-pr.ymlverify-sharesolve-opencistep + fix pathTest plan
Need help on this PR? Tag
@codesmithwith what you need.Summary by CodeRabbit