Revisited data processing scripts#29
Open
T4ras123 wants to merge 2 commits into
Open
Conversation
Support the revisited preprocessing workflow with grouped/counting utilities and shared serialization helpers so the data pipeline can be reviewed independently from training and evaluation changes. Made-with: Cursor
Keep the PR focused on the preprocessing implementation and shared helper code, and drop auxiliary scripts and token counting changes from the review. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and new features to the data preprocessing scripts for 3D molecular data. The main changes add support for new embedding types, allow configuration of binning via external files, and provide the option to use isomeric SMILES for canonicalization. The codebase is also refactored for better modularity and maintainability by moving utility functions and centralizing embedding logic.
Major feature additions:
"uniform_binned"and"quantile_binned", including command-line options in bothdata_preprocessing.pyandpreprocess_geom_grouped.py. [1] [2]--bin_config_pathargument to allow specifying a JSON file for binning configuration, used by the new embedding types. (src/molgen3D/data_processing/data_preprocessing.pyR455-R473, Fd44241bL245)--isomeric/--use_isomeric_smilesflag to optionally use isomeric SMILES as the canonical identifier for output samples. (src/molgen3D/data_processing/data_preprocessing.pyR455-R473, Fd44241bL245)Refactoring and code quality improvements:
get_embedding_func_and_config, removing hardcoded embedding registries from the scripts. [1] [2] [3] [4]copy_single_conformer_mol,extract_conf_meta, andsave_grouped_pickleto the sharedutilsmodule for better modularity. [1] [2] [3]Canonical SMILES handling:
Other improvements:
parse_coordinate_ranges, replacing inlineast.literal_evalusage. [1] [2]These changes make the preprocessing pipeline more flexible, configurable, and maintainable, supporting new embedding strategies and improving reproducibility.