Release v1.6.1#28
Merged
Merged
Conversation
added 2 commits
May 6, 2026 12:46
… context When run via curl | bash, the installer's stdin is a pipe, not a tty. The 'NXS_ZSH_IS_DEFAULT=true, not in zsh' branch was showing 'Activate zsh for this session: exec zsh' even though the bash process is ephemeral — the user's real session was already in zsh. Add NXS_STDIN_IS_TTY ([ -t 0 ]) and gate the exec-zsh advisory on it: - NXS_ZSH_IS_DEFAULT branch: suppress entirely when not a tty - NXS_BASHRC_EXECZSH branch: show the info line, hide 'Activate now:' - chsh branch: show the chsh line (real pending action), hide 'Or activate now:'
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release v1.6.1 — see CHANGELOG.md
Summary
curl | bashNXS_STDIN_IS_TTY([ -t 0 ]) to gate exec-zsh advice on interactive sessions onlyTest plan
curl ... | bash -s -- workstationon a machine where zsh is already the default shell → no shell advisory shown, "All done" if p10k configured./install.sh workstationfrom an interactive bash session → advisory still shown