Skip to content

Fix asyncio coroutine warning tests#22

Draft
Mirochill wants to merge 1 commit into
Xion:masterfrom
Mirochill:fix-18-asyncio-coroutine-warnings
Draft

Fix asyncio coroutine warning tests#22
Mirochill wants to merge 1 commit into
Xion:masterfrom
Mirochill:fix-18-asyncio-coroutine-warnings

Conversation

@Mirochill

Copy link
Copy Markdown

Closes #18

Summary:

  • Add an IS_PY34_ONLY test helper for the legacy asyncio.coroutine coverage.
  • Limit the @asyncio.coroutine tests to Python 3.4, where async def is not available.
  • Keep the existing async def coroutine tests for Python 3.5+.

Validation:

  • git diff --check HEAD~1..HEAD
  • Not run locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

asyncio.coroutine has been deprecated since Python 3.8 over async def syntax

1 participant