feat(server): improve operational diagnostics and writer tuning - #337
Merged
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 566d8e45a4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Details
Readiness semantics (#313)
ready: truewhen only audit/write diagnostics are degradedstatus: degradedandproblemsdetailsdocs/readiness.mdand add both HTTP/JSON regression combinationsToken cache diagnostics (#306, Phase 1 only)
nodelite_token_cache_hits_totalnodelite_token_cache_misses_totalnodelite_token_cache_evictions_totalThis PR intentionally implements instrumentation only. It does not close the remaining #306 benchmark, root-cause analysis, or hit-rate follow-up work.
This supersedes PR #307: it carries the diagnostic intent into production Prometheus metrics, adds eviction accounting and concurrency coverage, and is fully formatted. PR #307 only exposed test/load-test hit and miss counters and its Lint and Test job stopped at
cargo fmt --check.Writer scheduling configuration (#235)
Verification
cargo test --workspacecargo +stable fmt --all --checkcargo clippy --all-targets -- -D warningssh scripts/test-install-server-config.shCloses #313
Refs #306
Closes #235