docs: sync release, frontend, and GeoIP guidance - #336
Conversation
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b72cdce790
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - 敏感配置优先通过服务端文件、CLI 和受保护设置入口修改。 | ||
| - `/metrics` 与面板共用只读认证,适合接入 Prometheus。 | ||
| - 历史图用于展示基础趋势,不是每条 `metrics` 上报的完整归档。 | ||
| - GeoIP 默认启用在线 `ipwhois` provider。Server 会把解析出的 Agent 公网连接 IP 发送到第三方接口 `https://ipwho.is`,用于查询国家/地区以及可用的城市和坐标信息;局域网、回环和文档保留地址会在本地标记为 LAN,不发起该在线查询。 |
There was a problem hiding this comment.
Disclose dashboard-user IP lookups
With the default ipwhois provider, the disclosure is not limited to Agent addresses: successful Basic Auth requests call state.geoip.lookup(meta.client_ip) in nodelite-server/src/handlers/auth_routes/middleware.rs, and successful TOTP logins do the same in two_factor.rs, causing public dashboard-user IPs to be sent to ipwho.is as well. Operators relying on this privacy notice may therefore leave the feature enabled without realizing that viewer/admin addresses are disclosed; update this notice and the equivalent English README and example-config comments to describe both Agent and login-client lookups.
Useful? React with 👍 / 👎.
Summary
CHANGELOG.mdfrom v2.2.7 through v3.0.2-rc.2NODELITE_BUILD_VERSIONas the official tag-derived version source and workspace0.1.0as the local fallbackipwhoisGeoIP lookup, the public connection IP sent tohttps://ipwho.is, and offline/disabled alternativesVerification
git diff --check NodeLite/main...HEADpnpm --dir nodelite-server/web lintpnpm --dir nodelite-server/web typecheckpnpm --dir nodelite-server/web test(81 files, 490 tests)cargo test -p nodelite-proto parses_server_config_with_defaultscargo test --workspacecargo clippy --all-targets -- -D warningsconfig/server.example.tomlchanges are comments onlyCloses #318
Closes #310