Skip to content

feat(migration): add up and down migration for password_hash column #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leandromasotti wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

feat(migration): add up and down migration for password_hash column #278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...026061001_add_user_password_hash.down.sql → ...026061002_add_user_password_hash.down.sql
View file
Open in desktop
File renamed without changes.
0 .../2026061001_add_user_password_hash.up.sql → .../2026061002_add_user_password_hash.up.sql
View file
Open in desktop
File renamed without changes.
11 changes: 11 additions & 0 deletions database/migrations/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,14 @@ psql -d "$DATABASE_URL" -f database/migrations/2026051501_add_stream_tags.down.s
| File | Adds |
| ------------------------------------------ | ------------------------------------- |
| `2026051501_add_stream_tags.up.sql` | `tags`, `stream_tags`, supporting indexes |
| `2026061001_add_password_hash.up.sql` | `users.password_hash` (nullable → backfill → `NOT NULL`, no default) |
| `2026061002_add_user_password_hash.up.sql` | `users.password_hash` — redundant re-add, no-op after `2026061001` via `IF NOT EXISTS` |

> **Note on `2026061001` / `2026061002`:** both migrations add the same
> `users.password_hash` column. `2026061001_add_password_hash` is the
> canonical one — it matches `database/schema.sql` exactly
> (`VARCHAR(255) NOT NULL`, no default). `2026061002_add_user_password_hash`
> previously collided on the `2026061001` counter (see issue #203); it has
> been renumbered to keep counters unique. Because every `ADD COLUMN`
> uses `IF NOT EXISTS`, applying both in order leaves the canonical,
> default-free column in place and reproduces `schema.sql`.
Loading