fix: restrict bash in plan mode#314
Open
WqyJh wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes XiaomiMiMo#475
Type of change
What does this PR do?
Plan mode is documented as read-only, but the built-in plan agent did not set bash permissions, so bash inherited the default allow behavior. That left commands like
mkdir,touch, and shell redirects able to modify the workspace.This PR makes plan-mode bash default to deny and explicitly allows common read-only exploration commands:
pwd,ls,cat,grep,rg,find,git status,git diff,git log,git show,Get-ChildItem, andGet-Content. User-defined permission overrides still flow through the existing config merge path.How did you verify your code works?
Passed locally:
bun test test/agent/agent.test.ts -t "plan agent" --timeout 30000bun test test/tool/bash.test.ts -t "matches redirects in permission pattern" --timeout 30000bun test test/tool/bash.test.ts -t "always pattern has space before wildcard" --timeout 30000git diff --checkLocal limitation:
bun typecheckcurrently fails before reaching this change withsrc/storage/db.node.ts(1,30): error TS2307: Cannot find module 'node:sqlite' or its corresponding type declarations.Screenshots / recordings
No UI change.
Checklist
Mirrored from XiaomiMiMo/MiMo-Code#505 — original author @cnYui.