update to v0.6.0#69
Conversation
|
🛑 Stop! Do not merge manually.🛑 |
| if [[ "$JAVA_VERSION_MAJOR" != 17 && "$JAVA_VERSION_MAJOR" != 21 && "$JAVA_VERSION_MAJOR" != 23 && "$JAVA_VERSION_MAJOR" != 24 ]]; then | ||
| printf "${ERR}This Java version appears to be unsupported. You should upgrade it, or may have compile errors.${NC} Psoxy requires an Oracle-supported version of Java 17 or later; as of April 2025, this includes Java 17, 21, or 24. See https://maven.apache.org/install.html\n" | ||
| if $HOMEBREW_AVAILABLE; then printf "or as you have Homebrew available, run ${CODE}brew install openjdk@17${NC}\n"; fi | ||
| if [[ "$JAVA_VERSION_MAJOR" != 21 && "$JAVA_VERSION_MAJOR" != 25 && "$JAVA_VERSION_MAJOR" != 26 ]]; then |
There was a problem hiding this comment.
I don't think we should support non LTS versions (26), then why not the ones between 21 and 25?
if [[ "$JAVA_VERSION_MAJOR" -lt 21 ]]; then
There was a problem hiding this comment.
22-24 are unsupported generally ... not sure we should; but yeah, i guess reasonable to just not force people to upgrade; will add back in next version.
There was a problem hiding this comment.
as i recall, 24 has issues w some versions of maven though ...
There was a problem hiding this comment.
and this is warning, not blocker.
There was a problem hiding this comment.
the problem is that if they just blindly install java, they're going to have 26. installing something other than latest and linking it is non-trivial
2 participants
update to proxy release https://github.com/Worklytics/psoxy/releases/tag/v0.6.0