Update to full Dart 3.10#179
Merged
Merged
Conversation
robbecker-wf
commented
Feb 11, 2026
Member
Author
There was a problem hiding this comment.
Only dart format changes
robbecker-wf
commented
Feb 11, 2026
Member
Author
There was a problem hiding this comment.
The only dart file with changes that aren't just formatting
robbecker-wf
commented
Feb 11, 2026
| ActionsClass _actionsClassFromElement(ClassElement element, bool nndbEnabled) => | ||
| ActionsClass( | ||
| element.name, | ||
| element.name!, |
robbecker-wf
commented
Feb 11, 2026
| bool nndbEnabled, | ||
| ) => element.fields | ||
| .where((f) => _isReduxActions(f.type.element)) | ||
| .map((f) => ComposedActionClass(f.name!, f.type.getDisplayString())); |
Member
Author
There was a problem hiding this comment.
👀
Note the ! and the removal of withNullability: nndbEnabled
robbecker-wf
commented
Feb 11, 2026
| .map((s) => s.element is ClassElement ? s.element : null) | ||
| .whereType<ClassElement>() | ||
| .where(_isReduxActions) | ||
| .map((it) => _actionsClassFromElement(it, nndbEnabled)); |
robbecker-wf
commented
Feb 11, 2026
Comment on lines
+66
to
+67
| '${element.name!}-${field.name!}', | ||
| field.name!, |
robbecker-wf
commented
Feb 11, 2026
Comment on lines
+78
to
+82
| final fragment = field.firstFragment; | ||
| return _getGenerics( | ||
| fragment.libraryFragment.source.contents.data, | ||
| fragment.nameOffset!, | ||
| ); |
Member
Author
There was a problem hiding this comment.
field.source and field.nameOffset are gone ... so now we're calling those on field.firstFragment.
robbecker-wf
commented
Feb 11, 2026
Comment on lines
+86
to
+91
| final method = element.getGetter(field.name!); | ||
| final fragment = method!.firstFragment; | ||
| return _getGenerics( | ||
| fragment.libraryFragment.source.contents.data, | ||
| fragment.nameOffset!, | ||
| ); |
Member
Author
There was a problem hiding this comment.
same where with the deprecation removals
robbecker-wf
commented
Feb 11, 2026
Comment on lines
-82
to
+102
| final trimBeforeActionDispatcher = | ||
| trimAfterName.substring(trimAfterName.lastIndexOf('ActionDispatcher')); | ||
| final trimBeforeActionDispatcher = trimAfterName.substring( | ||
| trimAfterName.lastIndexOf('ActionDispatcher'), | ||
| ); | ||
| return trimBeforeActionDispatcher.substring( | ||
| trimBeforeActionDispatcher.indexOf('<') + 1, | ||
| trimBeforeActionDispatcher.lastIndexOf('>')); | ||
| trimBeforeActionDispatcher.indexOf('<') + 1, | ||
| trimBeforeActionDispatcher.lastIndexOf('>'), | ||
| ); |
robbecker-wf
commented
Feb 11, 2026
| element is ClassElement && _hasSuperType(element, 'ReduxActions'); | ||
|
|
||
| bool _isActionDispatcher(FieldElement element) => element.type | ||
| .getDisplayString(withNullability: true) |
Member
Author
There was a problem hiding this comment.
removed withNullability: true
robbecker-wf
commented
Feb 11, 2026
| .any((interfaceType) => interfaceType.element.name == type) && | ||
| classElement.allSupertypes.any( | ||
| (interfaceType) => interfaceType.element.name == type, | ||
| ) && |
robbecker-wf
commented
Feb 11, 2026
| ActionsClass actionsClass, | ||
| ) => element.constructors.length > 1 | ||
| ? _actionDispatcherClassTemplate(actionsClass) | ||
| : ''; |
robbecker-wf
commented
Feb 11, 2026
|
|
||
| String _actionDispatcherClassTemplate(ActionsClass actionsClass) => ''' | ||
| String _actionDispatcherClassTemplate(ActionsClass actionsClass) => | ||
| ''' |
Member
Author
There was a problem hiding this comment.
here and all below is just formatting changes
greglittlefield-wf
approved these changes
Feb 13, 2026
| var hasWrittenHeaders = false; | ||
| final nndbEnabled = await buildStep.inputLibrary | ||
| .then((value) => value.featureSet.isEnabled(Feature.non_nullable)); | ||
| final nndbEnabled = await buildStep.inputLibrary.then( |
There was a problem hiding this comment.
#nit If this version only supports Dart >=3, then this will always be true, and could be removed
Member
Author
|
QA +1 CI passes under Dart 3.10.9. Manual testing passes. |
btr-rmconsole-3
Bot
added
Merge Requirements Met
and removed
Merge Requirements Unmet
labels
Member
Author
|
@Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update to Dart 3.10.9, analyzer 10, and latest build packages
QA