Plugin Directory: Improve screenshot lightbox captions#697
Open
dan-zakirov wants to merge 3 commits into
Open
Conversation
Remove the Photon srcset for Plugin Directory screenshots so replaced assets keep using the ps.w.org URL with its revision query. Keep the Gallery block, lightbox, layout detection, captions, and reveal behavior unchanged.
Render screenshot captions in an overlay-level bar beneath the active image so long captions no longer cover screenshot content. Reserve viewport space before revealing captions and keep the core lightbox scale unitless so zoom in and zoom out remain stable for vertical screenshots. Reduce thumbnail hover repaint work by removing the frosted trigger backdrop in screenshot galleries.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
- Moved captions into a separate area below the image - Removed the dark gradient caption overlay from images - Changed caption text to the standard dark page color - Reserved caption space before final image sizing - Kept tall screenshots and long captions within the viewport - Added a subtle caption reveal animation on lightbox open - Reduced extra layout recalculations during the opening transition - Preserved Gallery block output, navigation, image sources, dimensions, layout detection, and cache behavior Affected: wordpress.org/public_html/wp-content/plugins/gallery-lightbox-enhancements/assets/lightbox-captions.css, wordpress.org/public_html/wp-content/plugins/gallery-lightbox-enhancements/assets/lightbox-captions.js
dan-zakirov
force-pushed
the
dan/meta-8289-lightbox-caption-animation
branch
from
925afa1 to
164c0cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of https://meta.trac.wordpress.org/ticket/8289, this updates screenshot gallery lightbox captions in the Plugin Directory.
Long captions should not cover the image, tall screenshots should stay within the viewport, and short captions should keep the clean centered presentation that works well for most plugins.
Overall, the opened gallery view is improved while keeping the existing Gallery block output, navigation, and image behavior intact.
Captions stay centered to avoid breaking the presentation for other plugins.