[GitHub Actions] Clarify npm override release failure comment#3771
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Clarifies the inline example explaining an npm 11 override conflict that can fail releases when dist manifests pin resolved versions but root overrides keep semver ranges.
Changes:
- Reworded the npm 11 override example comment to separate source manifest, generated dist manifest, and root override behavior.
- Added more explicit reference to PR #3745 and the exact mismatch that triggers npm 11 rejection.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Clarifies the inline example for the npm 11 override conflict that broke the package release.
Rationale
The previous wording was technically correct, but easy to misread because it compressed the source manifest, generated dist manifest, and root override into one sentence.
Implementation
Updates only the comment in
tools/scripts/check-publish-package-overrides.mjs.Testing instructions