Block Bindings: Update render tests#9748
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
left a comment
There was a problem hiding this comment.
Nice refactoring. Thank you for consolidating similar use cases and extending coverage 👍🏻
|
Committed in #60720. |
Backport of changes made to the tests in WordPress/gutenberg#71389.
Independently of that PR, I think these changes make sense, since they make the tests less verbose and less redundant.
The changes are basically as follows:
block_bindings_supported_attributes_{$block_name}filter to register atest/block's attribute as supported by Block Bindings, rather than using an actual block (Paragraph) for most tests.get_value_callbackworks correctly (accepts arguments; correctly includes symbols and numbers; return value is sanitized when rendered) into one, by using adataProvider.uses_contextproperty.No semantic changes have been made, at least not deliberately -- the tests should still cover the same expected behavior.
Trac ticket: https://core.trac.wordpress.org/ticket/63840
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.