Navigation Block: Deprecate obsolete Block Hooks helper functions#7849
Draft
ockham wants to merge 8 commits into
Draft
Navigation Block: Deprecate obsolete Block Hooks helper functions#7849ockham wants to merge 8 commits into
ockham wants to merge 8 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Closed
ockham
force-pushed
the
deprecate/navigation-block-block-hooks-helpers
branch
from
f933cdb to
e60ff09
Compare
Contributor
Author
|
TODO: Deprecate |
Contributor
Author
Done in c03008a and e4dddb2. These will require changes from WordPress/gutenberg#68926 to be synced over, and #8212 to land. |
…on_set_ignored_hooked_blocks_metadata
…gation_insert_hooked_blocks
ockham
force-pushed
the
deprecate/navigation-block-block-hooks-helpers
branch
from
e4dddb2 to
ed5f757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See WordPress/gutenberg#64676 and WordPress/gutenberg#67193.
Note that we cannot delete these functions from
navigation.phpmanually, as that file is generated from a Gutenberg file. As a result, this PR currently causes some fatal errors, as some function declarations are duplicated. We will have to wait for WordPress/gutenberg#64676 to be merged and sync'd over to this repo before we can merge this PR.Trac ticket:
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.