Theme JSON: replace top-level background style objects on merge#7697
Theme JSON: replace top-level background style objects on merge#7697ramonjd wants to merge 1 commit into
Conversation
…el background image objects are not replaced, rather they are merged. Blocks are already catered for via ::get_block_nodes().
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
andrewserong
left a comment
There was a problem hiding this comment.
As in the Gutenberg PR (WordPress/gutenberg#66656), the logic looks good to me, and this is smoke testing well in theme.json and the site editor. I haven't run into any issues as a result of replacing rather than merging the backgroundImage property.
LGTM! 🚀
A PR that syncs the Gutenberg PR:
This PR fixes an omission in the theme json merge logic where top-level background image objects are not replaced, rather they are merged. Blocks are already catered for via ::get_block_nodes().
To test, run
npm run test:php -- --filter=Tests_Theme_wpThemeJsonTrac ticket: https://core.trac.wordpress.org/ticket/62328