Update packages for WordPress 6.5 RC 2#6253
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@ockham Pinging you here to check the changes to Navigation are as expected based on your fix for the entities issue that was uncovered during RC 1 🙏 Also @youknowriad @dream-encode @swissspidy for review. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Aside: this whole file has a lot of incorrect multiline comments, incorrect docblocks (missing @since and documented params that don't actually exist, e.g. in block_core_navigation_insert_hooked_blocks_into_rest_response), and weird function_exists checks for functions that are clearly in core.
There was a problem hiding this comment.
We can correct any obvious documentation problems including comments, docblocks...etc.
However, this file is maintained in the Gutenberg repo and so there will be additional checks in the file given its home in Gutenberg.
Currently we don't have a process where we can ship different code in Core than in the Gutenberg repo when code is maintained in the Gutenberg repo (as this file is). We can explore a solution for future releases but we cannot solve that prior to RC2 today.
My opinion is:
- we fix any critical code issues (those you specifically identified) and move forward with package sync quickly in time for RC 2 13:00 UTC code freeze.
- we raise a followup PR to further standardise the remainder of the file in time for RC3
- we raise an Issue to discuss a means to improve compatibility with PHP files that are maintained in Gutenberg but which are synced to Core.
There was a problem hiding this comment.
Agree with Dave. Sorry about the coding standards issues, I probably introduced some of those myself and/or didn't catch them in review; I'm a bit surprised that they weren't flagged by WPCS in CI.
However, this file is maintained in the Gutenberg repo and so there will be additional checks in the file given it's home in Gutenberg.
Currently we don't have a process where we can ship different code in Core than in the Gutenberg repo when code is maintained in the Gutenberg repo (as this file is). We can explore a solution for future releases but we cannot solve that prior to RC2 today.
Yeah, this is crucial. Those function_exists checks are unfortunate, but they are currently required, due to the reasons that Dave mentioned.
In the future, we might be able to harmonize some of this code with what we have for templates (possibly rendering some of the code here obsolete), but that's clearly not within the scope for RC2. (I'll create a ticket for that shortly.)
For now, I agree with Dave's plan 👍
There was a problem hiding this comment.
In the future, we might be able to harmonize some of this code with what we have for templates (possibly rendering some of the code here obsolete), but that's clearly not within the scope for RC2. (I'll create a ticket for that shortly.)
|
This PR is being discussed in WP Core Slack and addressed in WordPress/gutenberg#59774 |
Confirming that it's fixed 🎉
|
ockham
left a comment
ockham
left a comment
There was a problem hiding this comment.
I've tested the changes to the Navigation block. Confirming that the entities issue is fixed ✅
LGTM!
|
The performance job seem to be failing, I doubt that it's limited to this PR but do we know anything about that? |
Seems to be related to Docker unable to download this. |
|
I'm re-publishing the |
|
We should also remove the pattern overrides code in this PR I think. |
|
Packages were published and I've updated this PR to reflect the changes there. |
|
Performance tests are failing due to errors during environment setup. Latest one is that it cannot download: https://downloads.wordpress.org/plugin/wordpress-importer.0.8.2.zip... The link goes to 404. |
|
@getdave That's just GitHub accidentally including the dots in the link. The actual download is |
|
Tests are ✅ Please can we now commit this? |
|
I think @youknowriad just did in https://core.trac.wordpress.org/changeset/57814, so closing |
4 participants
Packages update for the WP 6.5 RC2 release.
Based on
Trac ticket: https://core.trac.wordpress.org/ticket/60315
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.