Block Bindings: Don't show protected fields that are bound to blocks and post meta #6197
Closed
SantosGuillamot wants to merge 23 commits into
Closed
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in Gutenberg plugin, this pull request adds two safety checks to ensure block bindings don't leak private post meta:
It seems safer to add these limitations to ensure no unwanted data is leaked. And it can be explored later how to loosen these restrictions.
To do that this pull request:
$meta_keysthrough get_registered_meta_keys function to check if the specific key has theshow_in_restproperty enabled.Testing Instructions
Test it doesn't show the protected value when
show_in_restis falseshow_in_restset to false:Test protected custom field
show_in_resttrue but protect it. It can be done adding a_at the beginning of the key or using a filter like this one:Trac ticket: https://core.trac.wordpress.org/ticket/60651
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.