Font Library: Add post types and low level APIs by youknowriad · Pull Request #6027 · WordPress/wordpress-develop

youknowriad · 2024-02-05T09:43:00Z

This PR backports the font library post types and low level APIs to Core. This is the first step to include the font library entirely into Core. Once this merged, we'll open a PR with the necessary REST API controllers.

Trac ticket: https://core.trac.wordpress.org/ticket/59166

github-actions · 2024-02-05T09:43:34Z

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: youknowriad, get_dave, grantmkin, swissspidy, hellofromtonya, mukesh27, mcsf.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
Co-authored-by: getdave <get_dave@git.wordpress.org>
Co-authored-by: creativecoder <grantmkin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: hellofromtonya <hellofromtonya@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>
Co-authored-by: mcsf <mcsf@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

swissspidy

This seems to reintroduce or ignore things that were previously already flagged in #5285.

Can we make sure that the feedback from there is respected?

getdave · 2024-02-05T11:06:22Z

e2e tests are failing on await requestUtils.activatePlugin( 'gutenberg' );.

github-actions · 2024-02-05T11:09:19Z

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

The Plugin and Theme Directories cannot be accessed within Playground.
All changes will be lost when closing a tab with a Playground instance.
All changes will be lost when refreshing the page.
A fresh instance is created each time the link below is clicked.
Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

youknowriad · 2024-02-05T11:14:49Z

@getdave Yes, that means this PR conflicts with the latest Gutenberg, it means we probably need to bring these changes to the latest Gutenberg version and do a patch release of Gutenberg before committing this PR to Core. But it doesn't prevent this PR from being reviewed properly.

youknowriad · 2024-02-05T14:09:31Z

With the latest Gutenberg release, this PR passes all the tests now 🎉

mukeshpanchal27

Lest some quick feedbacks.

mukeshpanchal27 · 2024-02-05T15:06:38Z

+ */
+class Tests_Fonts_FontLibraryHooks extends WP_UnitTestCase {
+
+	public function test_deleting_font_family_deletes_child_font_faces() {


Add @ticket annotation in all tests that are added for ticket.

Hi @mukeshpanchal27 👋

Per the handbook, the @ticket annotation is only for bugfixes:

@ticket – A custom WordPress annotation. Use @ticket 12345 to indicate that a test addresses the bug described in ticket #12345. Internally, @ticket annotations are translated to @group, so that you can limit test runs to those associated with a specific ticket: $ phpunit --group 12345.

The tests have already have @group annotations for allowing its test to be run separately.

Are you okay with not including the @ticket?

getdave · 2024-02-05T16:56:31Z

Note also some fixes will be coming in here as soon as WordPress/gutenberg#58675 is in Gutenberg.

mcsf

My review consisted of minor things, and I don't want them to get in the way of what feels like a good PR. I don't love the WP_Font_Utils class, but we can refine that later.

getdave · 2024-02-05T20:05:12Z

I've applied the fixes from WordPress/gutenberg#58675.

Ideally should aim to do one final PR upstream in Gutenberg repo to resolve all outstanding review comments here.

getdave · 2024-02-05T20:27:45Z

More feedback being addressed in Gutenberg at WordPress/gutenberg#58691.

creativecoder · 2024-02-05T22:50:41Z

The updates from WordPress/gutenberg#58691, addressing changes requested in review comments here, have now been applied to this PR.

hellofromtonya

After @swissspidy flagged some feedback that was missed from the original Core PR, it was re-audited today. The missed feedback was addressed and needed changes resolved in 507f1d9 ✅
All feedback in this PR is addressed and, if required, code changes made. ✅

LGTM 👍

IMO it's ready for commit.

youknowriad · 2024-02-06T08:42:00Z

Commit here https://core.trac.wordpress.org/changeset/57539
I'll be opening a follow-up PR with the REST controllers shortly.

youknowriad · 2024-02-06T08:51:34Z

Follow-up PR here #6034

youknowriad requested a review from hellofromtonya February 5, 2024 09:43

youknowriad self-assigned this Feb 5, 2024

youknowriad mentioned this pull request Feb 5, 2024

Font Library: Add post types and low level APIs #6026

Closed

youknowriad mentioned this pull request Feb 5, 2024

Font Library: WordPress 6.5 Required Tasks WordPress/gutenberg#55277

Closed

25 tasks

Font Library: Add post types and low level APIs

2613c74

swissspidy reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-library.php Outdated

youknowriad force-pushed the add/font-library-apis branch from b513974 to 2613c74 Compare February 5, 2024 09:47

swissspidy reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-library.php Outdated

Comment thread src/wp-includes/fonts/class-wp-font-library.php Outdated

Comment thread src/wp-includes/fonts/class-wp-font-library.php

Comment thread src/wp-includes/fonts/class-wp-font-library.php Outdated

Make the mimetypes a test util

51bd927

youknowriad force-pushed the add/font-library-apis branch from 2d1d9b2 to 51bd927 Compare February 5, 2024 10:16

youknowriad added 2 commits February 5, 2024 11:18

Translate string

d7d70d3

Refactor font library

d4c1a1d

youknowriad requested a review from swissspidy February 5, 2024 10:36

youknowriad added 2 commits February 5, 2024 11:46

Fix unit tests

dbfebe3

Fix rewrite rules, set to false

b3fc572

Restore the get_allowed_font_mime_types function

bbf2f6b

This was referenced Feb 5, 2024

Font Library: Refactor as a singleton WordPress/gutenberg#58669

Merged

Font Library: Synchronize code with Gutenberg 17.6 WordPress/gutenberg#58671

Merged

getdave mentioned this pull request Feb 5, 2024

Plugin: Synchronize PHP changes for WordPress 6.5 release WordPress/gutenberg#57959

Closed

Remove useless file

d181167

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/fonts.php Outdated

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-settings.php Outdated

Consolidate fonts files

e6759b8

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/default-filters.php Outdated

Consolidate default filters

5d850d3

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-collection.php Outdated

Rename subpackage

3f6dce8

mukeshpanchal27 reviewed Feb 5, 2024

View reviewed changes

mcsf reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-library.php

Comment thread src/wp-includes/fonts/class-wp-font-library.php

Comment thread src/wp-includes/fonts/class-wp-font-collection.php

creativecoder mentioned this pull request Feb 5, 2024

Font Library: address feedback from wordpress-develop#6027 WordPress/gutenberg#58691

Merged

mcsf approved these changes Feb 5, 2024

View reviewed changes

Apply fixes from WordPress/gutenberg#58675

507f1d9

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts.php Outdated

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-collection.php

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-collection.php Outdated

hellofromtonya reviewed Feb 5, 2024

View reviewed changes

Comment thread src/wp-includes/fonts/class-wp-font-library.php Outdated

creativecoder mentioned this pull request Feb 5, 2024

Font collection registration: handling invalid slugs WordPress/gutenberg#58695

Closed

Applies updates from gutenberg#58691, addressing review comments so far

095fd85

hellofromtonya approved these changes Feb 5, 2024

View reviewed changes

youknowriad mentioned this pull request Feb 6, 2024

Font Library: Add REST API Controllers. youknowriad/wordpress-develop#4

Closed

youknowriad closed this Feb 6, 2024

youknowriad mentioned this pull request Feb 6, 2024

Font Library: Add all REST API endpoints. #6034

Closed

youknowriad deleted the add/font-library-apis branch February 6, 2024 08:51

matiasbenedetto mentioned this pull request Feb 6, 2024

Font Library: remove tests from classes that were already merged in core WordPress/gutenberg#58752

Merged

Conversation

youknowriad commented Feb 5, 2024

Uh oh!

github-actions Bot commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Core SVN

GitHub Merge commits

Uh oh!

Uh oh!

swissspidy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

getdave commented Feb 5, 2024

Uh oh!

github-actions Bot commented Feb 5, 2024

Test using WordPress Playground

Some things to be aware of

Uh oh!

youknowriad commented Feb 5, 2024

Uh oh!

youknowriad commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mukeshpanchal27 Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

hellofromtonya Feb 5, 2024

Choose a reason for hiding this comment

Uh oh!

getdave commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mcsf left a comment

Choose a reason for hiding this comment

Uh oh!

getdave commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

getdave commented Feb 5, 2024

Uh oh!

Uh oh!

Uh oh!

creativecoder commented Feb 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hellofromtonya left a comment

Choose a reason for hiding this comment

Uh oh!

youknowriad commented Feb 6, 2024

Uh oh!

youknowriad commented Feb 6, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

github-actions Bot commented Feb 5, 2024 •

edited

Loading

creativecoder commented Feb 5, 2024 •

edited

Loading