Backport background image block support from Gutenberg#5209
Closed
andrewserong wants to merge 9 commits into
Closed
Backport background image block support from Gutenberg#5209andrewserong wants to merge 9 commits into
andrewserong wants to merge 9 commits into
Conversation
1e7c9ea to
1538e1a
Compare
mukeshpanchal27
left a comment
Member
There was a problem hiding this comment.
Thanks @andrewserong for PR. Some quick feedback.
Contributor
Author
|
Thanks for the quick code style fixes @mukeshpanchal27! 👍 |
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
Co-authored-by: Mukesh Panchal <mukeshpanchal27@users.noreply.github.com>
062d571 to
b5dfb01
Compare
tellthemachines
approved these changes
Sep 19, 2023
tellthemachines
left a comment
Contributor
There was a problem hiding this comment.
Changes LGTM! Thanks for adding tests ❤️
Contributor
|
Committed in r56614. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport background image block support feature that was introduced in Gutenberg in WordPress/gutenberg#53934.
Note this PR backports the PHP parts of the block support. This can be safely done prior to the JS packages landing for core, as the UI for the feature will not be exposed until the JS packages are updated.
Testing this PR manually in
wordpress-developis possible via the following steps:block.jsonfile to includebackground: { backgroundImage: true }under thesupportskey. I.e. that section will look like the following:Skip the block.json cache so the changes to the
block.jsonfile are picked up. A quick way is to comment out the following lines:wordpress-develop/src/wp-includes/blocks.php
Lines 363 to 365 in 7b90f22
In a post or page, paste in the following block markup that displays a background image from
wordpress.org:Trac ticket: https://core.trac.wordpress.org/ticket/59357
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.