Skip to content

Editor: Sync packages to include gutenberg_ to wp_ prefix change#4748

Closed
ockham wants to merge 4 commits into
trunkfrom
update/sync-packages-wp-6-3-beta-1-gutenberg-prefix
Closed

Editor: Sync packages to include gutenberg_ to wp_ prefix change#4748
ockham wants to merge 4 commits into
trunkfrom
update/sync-packages-wp-6-3-beta-1-gutenberg-prefix

Conversation

@ockham

@ockham ockham commented Jun 28, 2023

Copy link
Copy Markdown
Contributor

To include this fix.

Trac ticket: https://core.trac.wordpress.org/ticket/58651


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Comment thread package.json Outdated
@ockham

ockham commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

I think I need to temporarily remove @wordpress/nux before running the sync script (npm run sync-gutenberg-packages -- --dist-tag=wp-6.3) (and then add it back) to get all the right version updates. Will do that now.

@ockham ockham force-pushed the update/sync-packages-wp-6-3-beta-1-gutenberg-prefix branch from 695818c to 95f5aa3 Compare June 28, 2023 22:06
@ockham

ockham commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

I think I need to temporarily remove @wordpress/nux before running the sync script (npm run sync-gutenberg-packages -- --dist-tag=wp-6.3) (and then add it back) to get all the right version updates. Will do that now.

Done.

@ockham ockham marked this pull request as ready for review June 28, 2023 22:07

@joemcgill joemcgill left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better to me

@sabernhardt

Copy link
Copy Markdown

https://core.trac.wordpress.org/ticket/58651

@spacedmonkey spacedmonkey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Ship it.

@spacedmonkey

Copy link
Copy Markdown
Member

@ockham CI seems to be failing :(

@ockham

ockham commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

@ockham CI seems to be failing :(

Dang. I think I need to npm run build:dev to update the script loader file...

@ockham

ockham commented Jun 28, 2023

Copy link
Copy Markdown
Contributor Author

Committed to Core trunk in https://core.trac.wordpress.org/changeset/56098.

@ockham ockham closed this Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants