Skip to content

WP Backport Block Supports: Add text columns (column count) to typography block supports#4622

Closed
ramonjd wants to merge 9 commits into
WordPress:trunkfrom
ramonjd:add/typography-columns-support
Closed

WP Backport Block Supports: Add text columns (column count) to typography block supports#4622
ramonjd wants to merge 9 commits into
WordPress:trunkfrom
ramonjd:add/typography-columns-support

Conversation

@ramonjd

@ramonjd ramonjd commented Jun 16, 2023

Copy link
Copy Markdown
Member

This PR adds the PHP changes for the following Gutenberg PRs:

Frontend changes also need to be ported and will be done before WP 6.3 beta (before June 27)

Testing:

npm run test:php -- --filter Tests_Theme_wpThemeJson

Trac ticket: https://core.trac.wordpress.org/ticket/58549

@ramonjd

ramonjd commented Jun 20, 2023

Copy link
Copy Markdown
Member Author

@aaronrobertshaw do these ported changes look okay to you?

@ramonjd ramonjd force-pushed the add/typography-columns-support branch from e3f0f2c to 3380152 Compare June 21, 2023 00:20
@aaronrobertshaw

Copy link
Copy Markdown

Thank you for wrangling this backport @ramonjd

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in WordPress/gutenberg#46566. As it's all for one feature, should that be part of this backport or separate?

The changes in this PR look good in terms of addressing WordPress/gutenberg#33587 though.

@ramonjd

ramonjd commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

I think we might need to also backport the addition of textColumns support to the style engine which was added to Gutenberg in WordPress/gutenberg#46566.

Good spotting. I'll add it to this PR. 👍

thanks

@ramonjd ramonjd changed the title Block Supports: Add text columns (column count) to typography block supports WP Backport Block Supports: Add text columns (column count) to typography block supports Jun 22, 2023

@tellthemachines tellthemachines left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up @ramonjd ! I spotted a missing since comment and added it in 😄

Code LGTM and in accordance with the Gutenberg PRs; it won't really be testable in the UI until npm packages are updated but I can confirm everything else in the typography support is still working correctly.

@tellthemachines

Copy link
Copy Markdown
Contributor

Committed in r55985 / 9a9a672.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

3 participants