Update the WP packages with fixes prior to WP 6.2 RC2 by Mamaduka · Pull Request #4234 · WordPress/wordpress-develop

Mamaduka · 2023-03-14T11:42:27Z

Trac ticket: https://core.trac.wordpress.org/ticket/57471

This updated the packages to the latest versions with the latest fixes.

WordPress/gutenberg@f22a3cb

Includes the following changes:

~~[Bug] Comments: Fix 'sprintf requires more than 1 params' error Comments: Fix 'sprintf requires more than 1 params' error gutenberg#49054 > Introduced in 6.1.1 (not in 6.2)~~ ❌
[Regression] Don't offer Classic block as a recovery action when not registered Don't offer Classic block as a recovery action when not registered gutenberg#49051 ✅
[i18n Change] Fix typo in the media-categories component Fix typo in the media-categories component gutenberg#49047
Hide navigation screen in site editor Hide navigation screen in site editor gutenberg#49043 ✅ > (Feature is not ready for 6.2 - see Make/Core post for details)[https://make.wordpress.org/core/2023/03/14/fyi-navigation-section-of-new-site-editor-experienced-removed-for-6-2-rc-2/]
[i18n Change] Site editor: Fix non-us spelling in sidebar Site editor: Fix non-us spelling in sidebar gutenberg#48976 ✅ > Agreed to fix this in RC
Site Editor: Fix lingering insertion point within template parts Fix lingering insertion point within template parts gutenberg#48913 ✅ > Regression was introduced in 6.2 cycle
Navigation Link: Remove color generation code Navigation Link: Remove color generation code gutenberg#48927 and Navigation Link: Don't remove 'block_core_navigation_link_build_css_colors' gutenberg#49064 ✅
Fix settings tab active state border in block inspector Fix settings tab active state border in block inspector gutenberg#48945 ✅ > This bug may have been introduced in the 6.2 cycle.
Fix text alignment in the Site Editor sidebar Fix text alignment in the Site Editor sidebar gutenberg#48959 ✅ Making template descriptions more prominent is part of 6.2, not unusure if this alignment issue was introduced in 6.2 or not.

Mamaduka · 2023-03-14T11:42:41Z

 					$children,
 					$block
 				);
-				$block_content .= sprintf( $inner_content );


See: WordPress/gutenberg#49054

Mamaduka · 2023-03-14T11:43:51Z

- * @param  bool  $is_sub_menu Whether the link is part of a sub-menu.
- * @return array Colors CSS classes and inline styles.
- */
-function block_core_navigation_link_build_css_colors( $context, $attributes, $is_sub_menu = false ) {


See: WordPress/gutenberg#48927

audrasjb · 2023-03-14T12:27:32Z

Alright, looks good to me.
Note for the Core commit: this also fixes Trac ticket 57883.

hellofromtonya · 2023-03-14T12:48:48Z

Currently reviewing. There is at least 1 fix (so far) that was a bug introduced in 6.1, not in 6.2.

hellofromtonya

Blocking commit until the review of the fixes is completed. Why? To ensure all fixes are bugs and/or regressions introduced in the 6.2 cycle. There is at least 1 so far from 6.1.

hellofromtonya · 2023-03-14T13:15:36Z

@Mamaduka I've reviewed each of the Gutenberg PRs to determine if each bug / regression was introduced in the 6.2 cycle.

This bug was not introduced in 6.2:

[Bug] Comments: Fix 'sprintf requires more than 1 params' error Comments: Fix 'sprintf requires more than 1 params' error gutenberg#49054 > Introduced in 6.1.1 (not in 6.2) ❌

This fix is removing a PHP function. Was this function introduced in 6.2?

Navigation Link: Remove color generation code Navigation Link: Remove color generation code gutenberg#48927 ❓ > Bug was introduced in 6.2 Beta cycle, but not in RC. And a PHP function is being removed. Need to investigate when this function was introduced into Core.

I also left comments on each of these PRs.

Mamaduka · 2023-03-14T13:26:16Z

@hellofromtonya,

Comments: Fix 'sprintf requires more than 1 params' error - Don't have a strong opinion here. I would love to fix the fatal error, but if it's out of the scope of the RCs, then happy to revert the change.
Navigation Link: Remove color generation code - We can also fix this issue without removing the function and applying changes from this area - https://github.com/WordPress/wordpress-develop/pull/4234/files#diff-e3c55a4e55bda8c2b88525cb3627924cefcfd1966f936ebb3370020eb296be94R110.

hellofromtonya · 2023-03-14T13:29:07Z

Navigation Link: Remove color generation code - We can also fix this issue without removing the function and applying changes from this area - https://github.com/WordPress/wordpress-develop/pull/4234/files#diff-e3c55a4e55bda8c2b88525cb3627924cefcfd1966f936ebb3370020eb296be94R110.

@Mamaduka Do you when that function was introduced into Core? If during 6.2, then removing is fine. Else, could be deprecated instead if not used and the alternative fix applied.

hellofromtonya · 2023-03-14T13:30:24Z

Comments: Fix 'sprintf requires more than 1 params' error - Don't have a strong opinion here. I would love to fix the fatal error, but if it's out of the scope of the RCs, then happy to revert the change.

This one has a Trac ticket open for it https://core.trac.wordpress.org/ticket/57883. Let's revert it from this PR and continue discussions in that Trac ticket. Sound good? @Mamaduka

Mamaduka · 2023-03-14T13:32:18Z

@hellofromtonya, definitely not in 6.2. Here is the PR that introduced the function into the Gutenberg plugin - WordPress/gutenberg#21075, so probably WP 5.5-5.6

hellofromtonya · 2023-03-14T13:37:09Z

definitely not in 6.2. Here is the PR that introduced the function into the Gutenberg plugin - WordPress/gutenberg#21075, so probably WP 5.5-5.6

Okay thank you @Mamaduka. A hard removal of the function breaks Core's BC (Backwards Compatibility) Promise. It can be deprecated instead or fixed. See my comment here WordPress/gutenberg#48927 (comment)

hellofromtonya · 2023-03-14T14:42:17Z

This one has a Trac ticket open for it https://core.trac.wordpress.org/ticket/57883. Let's revert it from this PR and continue discussions in that Trac ticket.

Sorry for misguidance here. @Mamaduka Let's leave this fix on this PR for now but make it a separate commit please. That way its commit can be excluded if there's a decision not to commit it.

Mamaduka · 2023-03-14T14:44:21Z

Comments: Fix 'sprintf requires more than 1 params' error - Reverted in WordPress/gutenberg@4486a6b.
Navigation Link: Remove color generation code - Feedback addressed in Navigation Link: Don't remove 'block_core_navigation_link_build_css_colors' gutenberg#49064.

Mamaduka · 2023-03-14T15:04:31Z

Let's leave this fix on this PR for now but make it a separate commit please. That way its commit can be excluded if there's a decision not to commit it.

@hellofromtonya, it needs to be in a separate package update; otherwise build process will overwrite the changes.

Can we include it in RC3 when the decision is reached?

hellofromtonya · 2023-03-14T15:21:11Z

Published package updates WordPress/gutenberg@356298f

hellofromtonya

Confirmed the package version numbers match the 2 publish releases WordPress/gutenberg@f22a3cb and WordPress/gutenberg@356298f ✅
Confirmed the removed PHP function is restored to avoid breaking BC ✅
Confirmed the sprintf() bug introduced in 6.1.0 is not in this package update as it is still being discussed ✅

Ready for commit 👍

hellofromtonya · 2023-03-14T15:46:22Z

Committed via https://core.trac.wordpress.org/changeset/55542 into trunk.

Update the WP packages with fixes prior to WP 6.2 RC2

378175f

Mamaduka commented Mar 14, 2023

View reviewed changes

Mamaduka requested review from audrasjb and hellofromtonya March 14, 2023 11:44

Mamaduka self-assigned this Mar 14, 2023

audrasjb approved these changes Mar 14, 2023

View reviewed changes

hellofromtonya requested changes Mar 14, 2023

View reviewed changes

hellofromtonya closed this Mar 14, 2023

hellofromtonya reopened this Mar 14, 2023

Feedback

bdaaa22

hellofromtonya approved these changes Mar 14, 2023

View reviewed changes

hellofromtonya closed this Mar 14, 2023

Mamaduka deleted the update/packages-wp62-pre-rc2 branch May 9, 2023 09:18

Conversation

Mamaduka commented Mar 14, 2023 • edited by hellofromtonya Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mamaduka Mar 14, 2023

Choose a reason for hiding this comment

Uh oh!

Mamaduka Mar 14, 2023

Choose a reason for hiding this comment

Uh oh!

audrasjb commented Mar 14, 2023

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

hellofromtonya left a comment

Choose a reason for hiding this comment

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

Mamaduka commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

Mamaduka commented Mar 14, 2023

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

Mamaduka commented Mar 14, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Mamaduka commented Mar 14, 2023

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

hellofromtonya left a comment

Choose a reason for hiding this comment

Uh oh!

hellofromtonya commented Mar 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Mamaduka commented Mar 14, 2023 •

edited by hellofromtonya

Loading

Mamaduka commented Mar 14, 2023 •

edited

Loading

Mamaduka commented Mar 14, 2023 •

edited

Loading