Block Bindings: Enable native List Item content binding#12204
Block Bindings: Enable native List Item content binding#12204cbravobernal wants to merge 1 commit into
Conversation
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Add `core/list-item` to the block attributes supported by block bindings so its `content` rich text can be bound, and cover the basic case in the render tests. Note: a List Item that contains a nested List keeps both in the same `<li>`; preserving that nested list when the content is bound is handled separately by the WP_Block::replace_html() inner-block fix. Props sauliusv, cbravobernal. See https://core.trac.wordpress.org/ticket/65406
cbravobernal
force-pushed
the
try/block-bindings-list-item-content
branch
from
b98a61f to
d2f2090
Compare
|
Committed in https://core.trac.wordpress.org/changeset/62518 |
1 participant
Trac ticket: https://core.trac.wordpress.org/ticket/65406
Adds
core/list-itemto the block attributes supported by block bindings, so a List Item'scontentrich text can be bound.Clean enablement — no render changes. Lands first. Tests cover the basic (non-nested) List Item binding, which needs no render-side change.
A List Item that contains a nested List keeps both inside the same
<li>; preserving that nested list whencontentis bound is the inner-block fix in #12113 (stacked on this PR).The fix can live for different blocks rather than the list-item. That's why I'm committing in a different PR for project hygiene.