Fix: State styles – clear background-image when hover sets a solid background-color#12182
Fix: State styles – clear background-image when hover sets a solid background-color#12182i-am-chitti wants to merge 3 commits into
background-image when hover sets a solid background-color#12182Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Hi there! 👋 Thank you for your contribution to WordPress! 💖 It looks like this is your first pull request to No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description. Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making. More information about how GitHub pull requests can be used to contribute to WordPress can be found in the Core Handbook. Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook. If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook. The Developer Hub also documents the various coding standards that are followed:
Thank you, |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
tellthemachines
left a comment
tellthemachines
left a comment
There was a problem hiding this comment.
The changes are consistent with WordPress/gutenberg#78992.
Just a couple minor docs issues below, otherwise looks good!
| * explicitly cleared. Without this, the gradient image layer remains visible | ||
| * on top of the solid hover color even when `!important` is used, because | ||
| * `background-color` and `background-image` are separate CSS properties. | ||
| * |
There was a problem hiding this comment.
This function needs an @since 7.1.0 tag here (see other functions in this file for comparison).
| /** | ||
| * Tests that background-image reset is added when a state sets a solid background-color. | ||
| * | ||
| * @covers ::wp_get_state_declarations_with_background_resets |
There was a problem hiding this comment.
The new tests should have @ticket 65239 tag (see other tests for comparison - 65239 being the trac ticket number this PR is linked with)
2 participants
Backport of WordPress/gutenberg#78992.
Description
When a block instance has a gradient applied to its default state and a solid background color applied to a pseudo-state like
:hover, the hover color never appears — the gradient keeps showing despite the state styles using!important.This is a CSS property mismatch: gradients render as
background(shorthand) orbackground-image, while solid colors render asbackground-color. Since!importantonly resolves ties between declarations of the same property, the gradient image layer is never cleared by the hover rule.Changes
Added
wp_get_state_declarations_with_background_resets()insrc/wp-includes/block-supports/states.php, called alongside the existingwp_get_state_declarations_with_fallback_border_styles().When compiled state declarations include
background-colorbut nobackgroundorbackground-imageof their own, it appendsbackground-image: unset !importantto clear any gradient from the default state.This mirrors the existing
border-stylefallback pattern already in the states support, and covers both:color.gradientpath (emitsbackgroundshorthand)background.gradientpath (emitsbackground-image)Trac ticket: https://core.trac.wordpress.org/ticket/65239
Use of AI Tools
No use of AI.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.