Skip to content

Remove polyfills #12161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cbuntingde wants to merge 2 commits into from
Closed

Remove polyfills #12161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5dd4662
Build/Test Tools: Remove .devcontainer/ and gitignore local-only plan…
cbuntingde Jun 12, 2026
813e70e
Remove polyfills (sodium_compat, class-json, class-snoopy, spl-autolo…
cbuntingde Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 0 additions & 25 deletions .devcontainer/devcontainer.json
View file
Open in desktop

This file was deleted.

29 changes: 0 additions & 29 deletions .devcontainer/docker-compose.yml
View file
Open in desktop

This file was deleted.

15 changes: 0 additions & 15 deletions .devcontainer/install-tools.sh
View file
Open in desktop

This file was deleted.

18 changes: 0 additions & 18 deletions .devcontainer/setup.sh
View file
Open in desktop

This file was deleted.

6 changes: 0 additions & 6 deletions .devcontainer/welcome-message.txt
View file
Open in desktop

This file was deleted.

5 changes: 5 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,3 +118,8 @@ wp-tests-config.php

# Visual regression test diffs
tests/visual-regression/specs/__snapshots__

# Local planning & agent-instruction files (never tracked, never committed)
/AGENTS.md
/MODERNIZATION-PLAN-v2.md
/PROJECT-SUMMARY.md
5 changes: 4 additions & 1 deletion composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,12 @@
"issues": "https://core.trac.wordpress.org/"
},
"require": {
"php": ">=8.5",
"ext-hash": "*",
"ext-json": "*",
"php": ">=7.4"
"ext-mbstring": "*",
"ext-mysqli": "*",
"ext-sodium": "*"
},
"suggest": {
"ext-dom": "*"
Expand Down
3 changes: 0 additions & 3 deletions phpunit.xml.dist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@
<directory suffix=".php">src/wp-includes/Requests</directory>
<directory suffix=".php">src/wp-includes/php-ai-client</directory>
<directory suffix=".php">src/wp-includes/SimplePie</directory>
<directory suffix=".php">src/wp-includes/sodium_compat</directory>
<directory suffix=".php">src/wp-includes/Text</directory>

<!-- Plugins and themes. -->
Expand All @@ -62,12 +61,10 @@

<file>src/wp-includes/atomlib.php</file>
<file>src/wp-includes/class-IXR.php</file>
<file>src/wp-includes/class-json.php</file>
<file>src/wp-includes/class-phpass.php</file>
<file>src/wp-includes/class-pop3.php</file>
<file>src/wp-includes/class-requests.php</file>
<file>src/wp-includes/class-simplepie.php</file>
<file>src/wp-includes/class-snoopy.php</file>
<file>src/wp-includes/deprecated.php</file>
<file>src/wp-includes/ms-deprecated.php</file>
<file>src/wp-includes/pluggable-deprecated.php</file>
Expand Down
40 changes: 0 additions & 40 deletions src/wp-admin/includes/file.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1415,46 +1415,6 @@ function verify_file_signature( $filename, $signatures, $filename_for_errors = f
);
}

// Verify runtime speed of Sodium_Compat is acceptable.
if ( ! extension_loaded( 'sodium' ) && ! ParagonIE_Sodium_Compat::polyfill_is_fast() ) {
$sodium_compat_is_fast = false;

// Allow for an old version of Sodium_Compat being loaded before the bundled WordPress one.
if ( method_exists( 'ParagonIE_Sodium_Compat', 'runtime_speed_test' ) ) {
/*
* Run `ParagonIE_Sodium_Compat::runtime_speed_test()` in optimized integer mode,
* as that's what WordPress utilizes during signing verifications.
*/
// phpcs:disable WordPress.NamingConventions.ValidVariableName
$old_fastMult = ParagonIE_Sodium_Compat::$fastMult;
ParagonIE_Sodium_Compat::$fastMult = true;
$sodium_compat_is_fast = ParagonIE_Sodium_Compat::runtime_speed_test( 100, 10 );
ParagonIE_Sodium_Compat::$fastMult = $old_fastMult;
// phpcs:enable
}

/*
* This cannot be performed in a reasonable amount of time.
* https://github.com/paragonie/sodium_compat#help-sodium_compat-is-slow-how-can-i-make-it-fast
*/
if ( ! $sodium_compat_is_fast ) {
return new WP_Error(
'signature_verification_unsupported',
sprintf(
/* translators: %s: The filename of the package. */
__( 'The authenticity of %s could not be verified as signature verification is unavailable on this system.' ),
'<span class="code">' . esc_html( $filename_for_errors ) . '</span>'
),
array(
'php' => PHP_VERSION,
'sodium' => defined( 'SODIUM_LIBRARY_VERSION' ) ? SODIUM_LIBRARY_VERSION : ( defined( 'ParagonIE_Sodium_Compat::VERSION_STRING' ) ? ParagonIE_Sodium_Compat::VERSION_STRING : false ),
'polyfill_is_fast' => false,
'max_execution_time' => ini_get( 'max_execution_time' ),
)
);
}
}

if ( ! $signatures ) {
return new WP_Error(
'signature_verification_no_signature',
Expand Down
2 changes: 0 additions & 2 deletions src/wp-admin/includes/update-core.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -756,7 +756,6 @@
// 6.3
'wp-includes/images/wlw',
'wp-includes/wlwmanifest.xml',
'wp-includes/random_compat',
// 6.4
'wp-includes/navigation-fallback.php',
'wp-includes/blocks/navigation/view-modal.min.js',
Expand Down Expand Up @@ -798,7 +797,6 @@
'wp-includes/js/dist/vendor/react.min.js.LICENSE.txt',
'wp-includes/js/dist/vendor/wp-polyfill-importmap.js',
'wp-includes/js/dist/vendor/wp-polyfill-importmap.min.js',
'wp-includes/sodium_compat/src/Core/Base64/Common.php',
'wp-includes/SimplePie/Author.php',
'wp-includes/SimplePie/Cache.php',
'wp-includes/SimplePie/Caption.php',
Expand Down
Loading
Loading