Add support for aspect ratio and related controls in viewport states#12077
Add support for aspect ratio and related controls in viewport states#12077tellthemachines wants to merge 2 commits into
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
whoops I closed the original ticket and this was closed too |
2734b0a to
48594ae
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I have now updated to match the latest from WordPress/gutenberg#78795 and human-reviewed all the code. |
There was a problem hiding this comment.
I did a check of the code and the port LGTM
I tried testing by hard-coding some block attributes and testing in the frontend, but I suspect there are some state/responsive pieces missing (?) because it wasn't showing me the results.
E.g.,
<!-- wp:image {"id":11,"width":"auto","height":"51px","aspectRatio":"3/4","scale":"cover","sizeSlug":"large","linkDestination":"none","style":{"tablet":{"dimensions":{"width":"270px","objectFit":"cover","aspectRatio":"1"}},"mobile":{"dimensions":{"objectFit":"cover","width":"73px","height":"264px"}}}} --> Anyway, things build fine and I couldn't see any side-effects when testing.
Ah maybe the incoming conflicts? |
yeah I just committed #12182 😅 I'll solve the conflicts and re-test to be sure. Thanks for reviewing! |
e35f3c3 to
6832566
Compare
|
Committed in https://core.trac.wordpress.org/changeset/62513. |
Trac ticket: https://core.trac.wordpress.org/ticket/65164
Changes from gutenberg: WordPress/gutenberg#78795
Use of AI Tools
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.