Skip to content

Remove hardcoded button colors from core theme.json #11708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Sukhendu2002 wants to merge 2 commits into
base: trunk
Choose a base branch
from
+28 −0
Draft

Remove hardcoded button colors from core theme.json #11708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8a37398
Remove hardcoded button colors from core theme.json
Sukhendu2002 May 5, 2026
82faafc
Automation: Updating built files with changes.
May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions tests/phpunit/tests/theme/wpThemeJsonResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1484,4 +1484,32 @@ public function test_block_style_variation_merge_order() {

$this->assertSameSetsWithIndex( $expected, $actual, 'Merged variation styles do not match.' );
}

/**
* Tests that core theme.json does not emit hardcoded button color declarations
* that would override theme styles due to CSS load order.
*
* @covers WP_Theme_JSON_Resolver::get_core_data
* @ticket 65162
*/
public function test_core_theme_json_does_not_set_button_colors() {
$stylesheet = WP_Theme_JSON_Resolver::get_core_data()->get_stylesheet( array( 'styles' ) );

preg_match( '/:root :where\(\.wp-element-button[^{]*\)\s*\{[^}]*\}/', $stylesheet, $matches );
$this->assertNotEmpty( $matches, 'Button element rule should exist in core stylesheet.' );

$button_rule = $matches[0];

$this->assertStringNotContainsString(
'background-color',
$button_rule,
'Core theme.json must not set a background-color on the button element.'
);

$this->assertStringNotContainsString(
'color:',
$button_rule,
'Core theme.json must not set any color property on the button element.'
);
}
}
Loading