Embeds: Fix get_site_icon_url() dropping fallback when attachment URL…

[Sukhendu2002]

Trac ticket: https://core.trac.wordpress.org/ticket/65098

Use of AI Tools

AI assistance: No

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props sukhendu2002, westonruter, mukesh27, sabernhardt.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[westonruter]

Can we add tests for get_site_icon_url() and the_embed_site_title() to cover the new code paths?

I see there are existing tests for get_site_icon_url() in tests/phpunit/tests/general/template.php but I don't see existing coverage for the_embed_site_title().

[Copilot]

Pull request overview

Fixes a regression where get_site_icon_url() could drop a provided fallback URL when the attachment URL lookup fails, and updates embed site-title rendering to avoid emitting broken/empty icon attributes.

Changes:

• Preserve the caller-provided fallback URL in get_site_icon_url() when wp_get_attachment_image_url() returns false.
• Refactor the_embed_site_title() to conditionally render the site icon markup and omit srcset when appropriate.
• Add PHPUnit coverage for the fallback behavior and embed site title icon output edge cases (attachment URL failure, empty URL, identical 1x/2x URLs, no site icon set).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
tests/phpunit/tests/general/template.php	Adds tests for get_site_icon_url() fallback retention and the_embed_site_title() icon/srcset behaviors.
src/wp-includes/general-template.php	Ensures attachment URL failures don’t overwrite a provided fallback URL in get_site_icon_url().
src/wp-includes/embed.php	Adjusts embed site title markup to avoid empty src/broken srcset and to omit the icon when URL is empty.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[mukeshpanchal27]

Thanks for the iterations. Changes looks good to me.

[westonruter]

Double-checking this.

With the following plugin code in place:

add_filter( 'wp_get_attachment_image_src', '__return_false' );

When accessing a post that has another post embedded:

Before:

After:

So it's working well for me.

[github-actions]

A commit was made that fixes the Trac ticket referenced in the description of this pull request.

SVN changeset: 62502
GitHub commit: 68cbdc9

This PR will be closed, but please confirm the accuracy of this and reopen if there is more work to be done.