Fix/tidy and gd tests#2527
Open
nickchomey wants to merge 12 commits into
Open
Conversation
…sed for initial image processing and dominant colours
…never do anything in any test
…ominant_color_get_dominant_color_data. So not redundant to call it afterwards
…e GD tests tun, though not for imagick)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…t stuff coming in other PR. Also, cleaner to just convert in one place for all editors
nickchomey
force-pushed
the
fix/tidy-and-gd-tests
branch
from
29a3234 to
ea2c183
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2524
Depends on #2523 (I cant be bothered to rebase back to trunk, and then back on top when that gets merged)
Relevant technical choices
I noticed some strange/redundant code in the dominant-color-images plugin so took it as an opportunity to do a bit of tidying up as well as implement tests for GD.
The commits are self-describing. Let me know if it is necessary to split this into a few PRs...
Use of AI Tools
I used Deepseek V4 via VS Code Github Copilot Chat to assist me. I reviewed and refactored its output.