Skip to content

Avoid forcing Imagick-only editor when Imagick lacks core format support #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 3 commits into from
+20 −11
Closed

Avoid forcing Imagick-only editor when Imagick lacks core format support #2522

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6505f41
Initial plan
Copilot Jun 6, 2026
3146b65
tests: avoid forcing imagick when core formats unavailable
Copilot Jun 6, 2026
e708b8f
tests: make imagick editor filter conditional on format support
Copilot Jun 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 20 additions & 11 deletions plugins/dominant-color-images/tests/test-dominant-color-image-editor-imagick.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,26 @@ public function set_up(): void {
$this->markTestSkipped( 'The Imagick PHP extension is not loaded.' );
}

add_filter(
'wp_image_editors',
static function ( array $editors ): array {
return array_filter(
$editors,
static function ( $editor ): bool {
return WP_Image_Editor_Imagick::class === $editor;
}
);
}
);
$required_formats = array( 'JPEG', 'PNG', 'GIF', 'WEBP' );
try {
$supported_formats = Imagick::queryFormats();
} catch ( Exception $exception ) {
$this->markTestSkipped( sprintf( 'Unable to query Imagick formats: %s', $exception->getMessage() ) );
}
$missing_formats = array_diff( $required_formats, $supported_formats );
if ( 0 === count( $missing_formats ) ) {
add_filter(
'wp_image_editors',
static function ( array $editors ): array {
return array_filter(
$editors,
static function ( $editor ): bool {
return WP_Image_Editor_Imagick::class === $editor;
}
);
}
);
}
}

/**
Expand Down
Loading