Skip to content

Add explanation for discarded modern image outputs #2518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabelivan wants to merge 1 commit into
base: trunk
Choose a base branch
from
+4 −1
Open

Add explanation for discarded modern image outputs #2518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion plugins/webp-uploads/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,10 @@ function webp_uploads_generate_avif_webp_setting_callback(): void {
<label for="perflab_modern_image_format">
<?php esc_html_e( 'Generate images in this format', 'webp-uploads' ); ?>
</label>
<p class="description" id="perflab_modern_image_format_description"><?php esc_html_e( 'Select the format to use when generating new images from uploaded images.', 'webp-uploads' ); ?></p>
<p class="description" id="perflab_modern_image_format_description">
<?php esc_html_e( 'Select the format to use when generating new images from uploaded images.', 'webp-uploads' ); ?>
<?php esc_html_e( 'Generated images may be discarded if the modern image format file is larger than the original uploaded image.', 'webp-uploads' ); ?>

@westonruter westonruter Jun 4, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this string be combined with the previous string?

@gabelivan gabelivan Jun 4, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept them separate intentionally to avoid changing the existing translatable string, since that string may already have translations. This way, only the newly added sentence needs to be translated.

That said, I’m happy to combine them if the preferred approach here is to give translators the full sentence context in a single string.

</p>
<?php if ( ! $avif_supported ) : ?>
<br />
<div class="notice notice-warning inline">
Expand Down
Loading