Bump the wordpress-packages group across 1 directory with 3 updates#2509
Conversation
Bumps the wordpress-packages group with 3 updates: [@wordpress/e2e-test-utils-playwright](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils-playwright), [@wordpress/env](https://github.com/WordPress/gutenberg/tree/HEAD/packages/env) and [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts). Updates `@wordpress/e2e-test-utils-playwright` from 1.46.0 to 1.47.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils-playwright/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/e2e-test-utils-playwright@1.47.0/packages/e2e-test-utils-playwright) Updates `@wordpress/env` from 11.6.0 to 11.7.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/env/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/env@11.7.0/packages/env) Updates `@wordpress/scripts` from 32.2.0 to 32.3.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/scripts@32.3.0/packages/scripts) --- updated-dependencies: - dependency-name: "@wordpress/e2e-test-utils-playwright" dependency-version: 1.47.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wordpress-packages - dependency-name: "@wordpress/env" dependency-version: 11.7.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wordpress-packages - dependency-name: "@wordpress/scripts" dependency-version: 32.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wordpress-packages ... Signed-off-by: dependabot[bot] <support@github.com>
|
@dependabot rebase |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
643a255 to
e8d2dbb
Compare
|
@dependabot rebase |
Bumps the wordpress-packages group with 3 updates in the / directory: [@wordpress/e2e-test-utils-playwright](https://github.com/WordPress/gutenberg/tree/HEAD/packages/e2e-test-utils-playwright), [@wordpress/env](https://github.com/WordPress/gutenberg/tree/HEAD/packages/env) and [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts). Updates `@wordpress/e2e-test-utils-playwright` from 1.46.0 to 1.47.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/e2e-test-utils-playwright/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/e2e-test-utils-playwright@1.47.0/packages/e2e-test-utils-playwright) Updates `@wordpress/env` from 11.6.0 to 11.7.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/env/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/env@11.7.0/packages/env) Updates `@wordpress/scripts` from 32.2.0 to 32.3.0 - [Release notes](https://github.com/WordPress/gutenberg/releases) - [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md) - [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/scripts@32.3.0/packages/scripts) --- updated-dependencies: - dependency-name: "@wordpress/e2e-test-utils-playwright" dependency-version: 1.47.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wordpress-packages - dependency-name: "@wordpress/env" dependency-version: 11.7.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wordpress-packages - dependency-name: "@wordpress/scripts" dependency-version: 32.3.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: wordpress-packages ... Signed-off-by: dependabot[bot] <support@github.com>
e8d2dbb to
32ffc9f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #2509 +/- ##
=======================================
Coverage 69.29% 69.29%
=======================================
Files 90 90
Lines 7723 7723
=======================================
Hits 5352 5352
Misses 2371 2371
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
westonruter
left a comment
There was a problem hiding this comment.
Now looking at the diff. The prettier fixes seem to indicate that @wordpress/scripts is no longer using the fork of Prettier to add additional whitespace.
Seeing the update here:
Updates
@wordpress/scriptsfrom 32.2.0 to 32.3.0
I'm confused because there is nothing in the changelog here: https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md#3230-2026-05-27
It seems something deeper is going on.
|
I'm getting Claude to take a look. |
The package-lock.json regeneration that pinned e2e-test-utils-playwright back to 1.46.0 silently flipped the hoisted prettier from wp-prettier@3.0.3 to vanilla prettier@3.8.3, which caused the JS lint reformatting. No package's prettier declaration actually changed. Pin prettier to npm:wp-prettier@3.0.3 via overrides so the WordPress fork is hoisted to node_modules/prettier again, and revert the JS/TS files back to WordPress whitespace style. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
👉🏻 When we merge this, let's use squash and merge to prevent the blame from getting touched after all those files were changed. |
This comment was marked as outdated.
This comment was marked as outdated.
CI was green with 1.47.0 on the original dependabot bump (32ffc9f); the declared deps and peer deps are identical between 1.46.0 and 1.47.0, and the lint failures that prompted the pin were actually caused by the prettier hoist flip, not by the e2e version. Restore the bump to ^1.47.0 and drop the e2e override so the (now ungated) E2E job can verify it. Keep the prettier override, which guards against the wp-prettier hoist flip independently of the e2e version. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Bumping to 1.47.0 made the E2E job fail with: Cannot find module '.../@wordpress/e2e-test-utils-playwright/src/index.ts' at @wordpress/scripts/config/playwright/global-setup.js Root cause: 1.47.0 and 1.48.0 ship a broken "exports" map whose default condition points to "./src/index.ts", but src/ is not included in the published tarball (and the build/index.cjs entry from 1.46.0 was dropped). Any require() of the package therefore resolves to a missing file. This is an upstream packaging regression, not a version mismatch with @wordpress/ scripts, so bumping further does not help. Pin back to 1.46.0 until the upstream exports bug is fixed. The prettier override is retained independently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
1.47.0 shipped an exports.default pointing to ./src/index.ts without including src/ in the published tarball, which broke require() in @wordpress/scripts' playwright global-setup. That was fixed upstream in WordPress/gutenberg#78847 ("add src to published NPM files"), released in 1.48.0 — the published 1.48.0 tarball now includes src/index.ts, so the exports map resolves. Bump to ^1.48.0 and drop the e2e override now that the upstream package is fixed. The prettier override is retained independently to keep wp-prettier hoisted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This comment was marked as outdated.
This comment was marked as outdated.
1.48.0 (via WordPress/gutenberg#78847) added src/ to the published tarball, but the package now ships raw TypeScript source and points exports.default at ./src/index.ts. @wordpress/scripts' playwright global-setup.js loads it with a plain CommonJS require(), and Playwright's transpiler skips node_modules, so the E2E job fails with: SyntaxError: Unexpected token 'export' at @wordpress/scripts/config/playwright/global-setup.js:9 @wordpress/scripts 32.3.0 and 32.4.0 have identical global-setup.js, so bumping scripts does not help. 1.46.0 (which ships build/index.cjs) remains the only version consumable from npm in this setup. Pin back to 1.46.0. The prettier override is retained independently. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Note This comment was written by Claude (Claude Code), acting on behalf of @westonruter. It supersedes all my earlier comments (now marked outdated) and reflects the final, verified understanding. Full summaryThis PR tangled together two unrelated problems. Both are now understood; here is the complete picture including a wrong turn that CI corrected. 1. The Prettier reformatting was a lockfile hoisting accident — not a Prettier changeThe
So regenerating the lock to pin e2e flipped the hoist → vanilla Prettier → mass reformatting. Fix (d2ef6ca): pin the fork so the coin flip can't recur, and revert the reformatting (files now match "overrides": { "prettier": "npm:wp-prettier@3.0.3" }(7adffee cleaned up a few workflow YAML files the reformatter had incidentally touched.) This override is the durable fix and stays regardless of the e2e outcome — without it, the next lockfile regeneration can flip Prettier again. Validation: integrity hashes match the registry, 2. The e2e pin to 1.46.0 is genuinely required — 1.47.0 and 1.48.0 are both unusable from npmThe pin was originally attributed to a vague "version mismatch." Investigation (and a deliberately tested wrong turn, confirmed by the now-ungated E2E job) produced the real picture:
Both failures occur in
Bumping Resolution (081f2b3): pinned back to 1.46.0 via Where this leaves the PR
Recommended follow-ups
|
Bumps the wordpress-packages group with 3 updates in the / directory: @wordpress/e2e-test-utils-playwright, @wordpress/env and @wordpress/scripts.
Updates
@wordpress/e2e-test-utils-playwrightfrom 1.46.0 to 1.47.0Changelog
Sourced from @wordpress/e2e-test-utils-playwright's changelog.
Commits
d653c5fchore(release): publish065fa3bUpdate changelog filesf63ca66Merge changes published in the Gutenberg plugin "release/23.3" branch7f4e229Update changelog filesb5afac3Merge changes published in the Gutenberg plugin "release/23.3" branchfee7eecUpdate changelog filesf34b1f7Merge changes published in the Gutenberg plugin "release/23.3" branchUpdates
@wordpress/envfrom 11.6.0 to 11.7.0Changelog
Sourced from @wordpress/env's changelog.
Commits
d653c5fchore(release): publish065fa3bUpdate changelog filesf63ca66Merge changes published in the Gutenberg plugin "release/23.3" branch7f4e229Update changelog filesb5afac3Merge changes published in the Gutenberg plugin "release/23.3" branchfee7eecUpdate changelog filesUpdates
@wordpress/scriptsfrom 32.2.0 to 32.3.0Changelog
Sourced from @wordpress/scripts's changelog.
Commits
d653c5fchore(release): publish065fa3bUpdate changelog filesf63ca66Merge changes published in the Gutenberg plugin "release/23.3" branch7f4e229Update changelog filesb5afac3Merge changes published in the Gutenberg plugin "release/23.3" branchfee7eecUpdate changelog filesf34b1f7Merge changes published in the Gutenberg plugin "release/23.3" branch