Restore wordpress/plugin-check-action once upstream wp-env bug is fixed#2503
Draft
westonruter wants to merge 1 commit into
Draft
Restore wordpress/plugin-check-action once upstream wp-env bug is fixed#2503westonruter wants to merge 1 commit into
westonruter wants to merge 1 commit into
Conversation
This reverts commit 56c61e6. That commit was a temporary workaround for a wp-env URL-source download bug exposed by Node.js 24.16 in the ubuntu-24.04 runner image. It inlined the steps from wordpress/plugin-check-action so we could omit the URL plugin entry from .wp-env.json (the trigger) and install plugin-check via wp-cli post-boot, plus pinned @wordpress/env to 11.7.0. This restores the simpler `uses: wordpress/plugin-check-action@…` setup. Should only be merged after the upstream tickets referenced in the PR description are resolved. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
westonruter
added
[Type] Enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2496's workflow commit (56c61e6), restoring the simpler
uses: wordpress/plugin-check-action@…setup in.github/workflows/plugin-check.yml.That commit was a temporary workaround for an
@wordpress/envURL-source download bug exposed by Node.js 24.16 in theubuntu-24.04runner image:wp-env startwould silently exit 0 (without booting Docker) when.wp-env.jsoncontained any HTTP-URL plugin entry — andwordpress/plugin-check-actionauto-generates such a.wp-env.json. The workaround inlined the action's steps so we could installplugin-checkviawp-clipost-boot instead, and pinned@wordpress/envto11.7.0.Drafted now so it's ready to merge once both upstream tickets are resolved:
wp-env startfirst. plugin-check-action#579 — the action stops emitting a URL plugin entry (or otherwise dodges the wp-env bug)When both are checked, this PR is safe to merge. Until then, leave as draft.
Test plan
ubuntu24/20260525.161or later runner images (where the bug originally manifested).🤖 Generated with Claude Code