Skip to content

Modern Image Formats: link to FAQ from settings section #2480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Gilmoursa wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Modern Image Formats: link to FAQ from settings section #2480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5601df6
Modern Image Formats: link to FAQ from settings section
Gilmoursa May 15, 2026
ff85961
Tests: cover settings section callback registration in add_media_sett…
Gilmoursa May 15, 2026
bf1b6eb
Modern Image Formats: use closure for settings section description, n…
Gilmoursa May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion plugins/webp-uploads/settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,19 @@ function webp_uploads_add_media_settings_fields(): void {
add_settings_section(
'perflab_modern_image_format_settings',
_x( 'Modern Image Formats', 'settings page section name', 'webp-uploads' ),
'__return_empty_string',
static function (): void {
printf(
'<p>%s</p>',
wp_kses(
sprintf(
/* translators: %s: URL to the plugin FAQ on WordPress.org */
__( 'If modern format images are not being generated after upload, see the <a href="%s">FAQ</a> for common reasons.', 'webp-uploads' ),
'https://wordpress.org/plugins/webp-uploads/#faq'
),
array( 'a' => array( 'href' => array() ) )
)
);
},
'media',
array(
'before_section' => '<div id="modern-image-formats">',
Expand Down
18 changes: 18 additions & 0 deletions plugins/webp-uploads/tests/test-settings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,24 @@

class Test_WebP_Uploads_Settings extends WP_UnitTestCase {

/**
* @covers ::webp_uploads_add_media_settings_fields
*/
public function test_webp_uploads_add_media_settings_fields_section_description(): void {
global $wp_settings_sections;
webp_uploads_add_media_settings_fields();

$callback = $wp_settings_sections['media']['perflab_modern_image_format_settings']['callback'];
$this->assertIsCallable( $callback );

ob_start();
call_user_func( $callback );
$output = ob_get_clean();

$this->assertStringContainsString( 'https://wordpress.org/plugins/webp-uploads/#faq', $output );
$this->assertStringContainsString( '<a href=', $output );
}

/**
* @covers ::webp_uploads_add_settings_action_link
*/
Expand Down
Loading